Skip to content

Commit bd29732

Browse files
committed
Do not unnecessarily read JSON files when no formatters are enabled
Related to #57.
1 parent de70e2c commit bd29732

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

telegram-history-dump.rb

+16-14
Original file line numberDiff line numberDiff line change
@@ -352,24 +352,26 @@ def save_progress
352352
end
353353
$dumper.end_backup
354354

355-
$log.info('Formatting messages') unless enabled_formatters.empty?
356-
enabled_formatters.each do |formatter|
357-
formatter.start_backup(backup_list)
358-
end
359-
backup_list.each do |dialog|
360-
dialog_progress = $progress[dialog['id'].to_s]
361-
json_file = File.join(get_backup_dir, dialog_progress.dumper_state['outfile'])
362-
messages = []
363-
File.open(json_file, 'r:UTF-8').each do |line|
364-
messages.push(JSON.parse(line))
355+
unless enabled_formatters.empty?
356+
$log.info('Formatting messages')
357+
enabled_formatters.each do |formatter|
358+
formatter.start_backup(backup_list)
359+
end
360+
backup_list.each do |dialog|
361+
dumper_outfile = $progress[dialog['id'].to_s].dumper_state['outfile']
362+
json_file = File.join(get_backup_dir, dumper_outfile)
363+
messages = []
364+
File.open(json_file, 'r:UTF-8').each do |line|
365+
messages.push(JSON.parse(line))
366+
end
367+
enabled_formatters.each do |formatter|
368+
formatter.format_dialog(dialog, messages)
369+
end
365370
end
366371
enabled_formatters.each do |formatter|
367-
formatter.format_dialog(dialog, messages)
372+
formatter.end_backup
368373
end
369374
end
370-
enabled_formatters.each do |formatter|
371-
formatter.end_backup
372-
end
373375

374376
if cli_opts.kill_tg
375377
connect_socket

0 commit comments

Comments
 (0)