Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invite by email table overflows in mobile viewport #7273

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

harshit078
Copy link
Contributor

@harshit078 harshit078 commented Sep 26, 2024

##Description

Before

Screen.Recording.2024-09-27.at.1.30.14.AM.mov
Screenshot 2024-09-27 at 1 30 52 AM

After

Screenshot 2024-09-27 at 1 34 11 AM
Screen.Recording.2024-09-27.at.1.34.39.AM.mov

Note

I've added 2 implementations and if either doesn't follow design rules then it can be changed-

  • Made the trash icon accent danger
  • When emails are long, given scroll for ease of convience.

@harshit078 harshit078 changed the title fix: Improved layout and made it mobile friendly fix: Invite by email table overflows in mobile viewport Sep 26, 2024
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request improves the layout of the workspace members settings page, focusing on mobile responsiveness and addressing table overflow issues.

  • Introduced StyledTableRow and StyledTableCell components with mobile-specific styling in SettingsWorkspaceMembers.tsx
  • Added media query for mobile viewport to adjust table layout on smaller screens
  • Modified StyledTableCell to handle long email inputs by adding overflow: scroll and text-overflow: ellipsis
  • Adjusted gridAutoColumns for StyledTableRow to improve spacing on mobile devices
  • Implemented these changes to solve the table overflow issue reported in Invite by email table overflows in mobile viewport #7253

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ehconitin
Copy link
Contributor

Note

I've added 2 implementations and if either doesn't follow design rules then it can be changed-

  • Made the trash icon accent danger
  • When emails are long, given scroll for ease of convience.

@Bonapara

@Bonapara
Copy link
Member

The video won't play, but scrolling through the emails sounds cool! We should keep the icon gray since our design system currently doesn't include colors for icon buttons.

@ehconitin
Copy link
Contributor

video reupload -
@Bonapara

371299428-7a4f6f9a-7fef-42f1-a226-59a1d73767f4.mov

@Bonapara
Copy link
Member

Let's make the trash icons gray and we're good!

@harshit078
Copy link
Contributor Author

@Bonapara Fixed the icon !

@ehconitin
Copy link
Contributor

1

@harshit078 Thanks for this PR, could you also handle these changes?

  1. Align the Email column header and its corresponding content to the left.
  2. Align the Expires In column header to the left.
  3. Ensure that the email icon stays fixed in place while the email text scrolls if necessary.

@harshit078
Copy link
Contributor Author

1

@harshit078 Thanks for this PR, could you also handle these changes?

  1. Align the Email column header and its corresponding content to the left.
  2. Align the Expires In column header to the left.
  3. Ensure that the email icon stays fixed in place while the email text scrolls if necessary.

Note

  • Fixed email column header to left
  • The expires in column is aligned with its content when refreshed then only the tag takes width
  • Gave smooth and fixed scroll animation which makes it scroll back to its position and only gave scroll to mobile viewport
Screen.Recording.2024-09-29.at.4.20.04.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants