-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Invite by email table overflows in mobile viewport #7273
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request improves the layout of the workspace members settings page, focusing on mobile responsiveness and addressing table overflow issues.
- Introduced
StyledTableRow
andStyledTableCell
components with mobile-specific styling inSettingsWorkspaceMembers.tsx
- Added media query for mobile viewport to adjust table layout on smaller screens
- Modified
StyledTableCell
to handle long email inputs by addingoverflow: scroll
andtext-overflow: ellipsis
- Adjusted
gridAutoColumns
forStyledTableRow
to improve spacing on mobile devices - Implemented these changes to solve the table overflow issue reported in Invite by email table overflows in mobile viewport #7253
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
The video won't play, but scrolling through the emails sounds cool! We should keep the icon gray since our design system currently doesn't include colors for icon buttons. |
video reupload - 371299428-7a4f6f9a-7fef-42f1-a226-59a1d73767f4.mov |
Let's make the trash icons gray and we're good! |
@Bonapara Fixed the icon ! |
@harshit078 Thanks for this PR, could you also handle these changes?
|
Note
Screen.Recording.2024-09-29.at.4.20.04.PM.mov |
##Description
Before
Screen.Recording.2024-09-27.at.1.30.14.AM.mov
After
Screen.Recording.2024-09-27.at.1.34.39.AM.mov
Note
I've added 2 implementations and if either doesn't follow design rules then it can be changed-
accent danger