Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context.DOMAIN_NAME is localhost:3000 even when running through ngrok #474

Open
coaxial opened this issue Apr 23, 2023 · 1 comment
Open

Comments

@coaxial
Copy link

coaxial commented Apr 23, 2023

I am not a paid ngrok.io user, and in my functions I have code that uses context.DOMAIN_NAME to pass options do Dial and record callbacks.

When running locally with npx twilio-run --live --inspect --env --ngrok, the value of context.DOMAIN_NAME is localhost:3000 instead of the actual ngrok hostname.

I have tried hardcoding DOMAIN_NAME=<ngrok domain name> after launching the server, but the env vars don't update then. And I can't set it up ahead of time because the ngrok domain name is random and not known in advance.

It would be nice to have context.DOMAIN_NAME return the ngrok domain name when run with the --ngrok option.

@welcome
Copy link

welcome bot commented Apr 23, 2023

Thank you so much for opening your first issue in this project! We'll try to get back to it as quickly as possible. While you are waiting...here's a random picture of a corgi (powered by dog.ceo)

picture of dog

@makserik makserik added this to the Improvements/Nice to haves milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants