Enforce black code formatting

[tristanlatr]

I'm opening this issue to talk about how should we enforce code formatting (not whether we should enforce it).

We basically have two options:

• Reformat the whole codebase inside a single massive commit and add the commit sha to ignored commits in git blame.
• Use something like darker which apply incremental code formatting.

I don't have a strong opinion, so I'de like to request yours @adiroiban @glyph, thanks

[glyph]

Option 1 is obviously simpler and quicker, and, all things being equal, I tend to prefer it.

However, the major reason not to do things that way is to avoid merge conflicts with work in progress.

I see we have 17 PRs outstanding — most of them by you :). If those PRs are amenable to a simple rebase against the reformat, and it won't create big problems, then let's just do it that way.

IIRC the way we dealt with this on Twisted itself was to have a script that would rebase commits with blackened versions of themselves, which mostly addressed the problem. I don't remember what happened to that script though, it's been a while.

So: if the conflicts are a problem, using darker until we have fewer outstanding PRs and then doing the all-at-once thing should address that. Otherwise, let's format all at once and move on as quickly as we can.

Thanks for asking!

[tristanlatr]

Hello @glyph and thanks for your input, I did a little digging of https://github.com/twisted/twisted/pull/1380/files and https://github.com/twisted/twisted/pull/1381/files but did not find this script you are talking about...

[glyph]

Hello @glyph and thanks for your input, I did a little digging of https://github.com/twisted/twisted/pull/1380/files and https://github.com/twisted/twisted/pull/1381/files but did not find this script you are talking about...

I think maybe we just did it manually for all PRs, with a git rebase --exec=... one-liner like this? https://stackoverflow.com/a/73982786/13564