From 8b9b4b24136c628c874400ad1e9dd3a4a0a2c9bc Mon Sep 17 00:00:00 2001 From: Adi Roiban Date: Tue, 7 Nov 2023 16:25:10 +0000 Subject: [PATCH 1/5] venv/bin/towncrier build --yes --- NEWS.rst | 18 ++++++++++++++++++ src/towncrier/_version.py | 2 +- src/towncrier/newsfragments/538.bugfix | 1 - src/towncrier/newsfragments/558.misc | 0 src/towncrier/newsfragments/559.misc | 0 src/towncrier/newsfragments/562.bugfix | 1 - src/towncrier/newsfragments/562.bugfix.1 | 2 -- 7 files changed, 19 insertions(+), 5 deletions(-) delete mode 100644 src/towncrier/newsfragments/538.bugfix delete mode 100644 src/towncrier/newsfragments/558.misc delete mode 100644 src/towncrier/newsfragments/559.misc delete mode 100644 src/towncrier/newsfragments/562.bugfix delete mode 100644 src/towncrier/newsfragments/562.bugfix.1 diff --git a/NEWS.rst b/NEWS.rst index 9db34e74..e732978f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -5,6 +5,24 @@ Release notes .. towncrier release notes start +towncrier 23.11.0rc1 (2023-11-07) +================================= + +Bugfixes +-------- + +- ``build`` now treats a missing fragments directory the same as an empty one, consistent with other operations. (`#538 `_) +- Fragments with filenames like `fix-1.2.3.feature` are now associated with the ticket `fix-1.2.3`. + In previous versions they were incorrectly associated to ticket `3`. (`#562 `_) +- Orphan newsfragments containing numeric values are no longer accidentally associated to tickets. In previous versions the orphan marker was ignored and the newsfragment was associated to a ticket having the last numerical value from the filename. (`#562 `_) + + +Misc +---- + +- `#558 `_, `#559 `_ + + towncrier 23.10.0 (2023-10-24) ============================== diff --git a/src/towncrier/_version.py b/src/towncrier/_version.py index 1c086269..7feac3f9 100644 --- a/src/towncrier/_version.py +++ b/src/towncrier/_version.py @@ -11,7 +11,7 @@ # For dev - Version('towncrier', 23, 8, 1, dev=0) # For RC - Version('towncrier', 23, 9, 0, release_candidate=1) # For final - Version('towncrier', 23, 9, 0) -__version__ = Version("towncrier", 23, 10, 1, dev=0) +__version__ = Version("towncrier", 23, 11, 0, release_candidate=1) # The version is exposed in string format to be # available for the hatching build tools. _hatchling_version = __version__.short() diff --git a/src/towncrier/newsfragments/538.bugfix b/src/towncrier/newsfragments/538.bugfix deleted file mode 100644 index 3a6fbf34..00000000 --- a/src/towncrier/newsfragments/538.bugfix +++ /dev/null @@ -1 +0,0 @@ -``build`` now treats a missing fragments directory the same as an empty one, consistent with other operations. diff --git a/src/towncrier/newsfragments/558.misc b/src/towncrier/newsfragments/558.misc deleted file mode 100644 index e69de29b..00000000 diff --git a/src/towncrier/newsfragments/559.misc b/src/towncrier/newsfragments/559.misc deleted file mode 100644 index e69de29b..00000000 diff --git a/src/towncrier/newsfragments/562.bugfix b/src/towncrier/newsfragments/562.bugfix deleted file mode 100644 index 623ceab8..00000000 --- a/src/towncrier/newsfragments/562.bugfix +++ /dev/null @@ -1 +0,0 @@ -Orphan newsfragments containing numeric values are no longer accidentally associated to tickets. In previous versions the orphan marker was ignored and the newsfragment was associated to a ticket having the last numerical value from the filename. diff --git a/src/towncrier/newsfragments/562.bugfix.1 b/src/towncrier/newsfragments/562.bugfix.1 deleted file mode 100644 index d751ebe8..00000000 --- a/src/towncrier/newsfragments/562.bugfix.1 +++ /dev/null @@ -1,2 +0,0 @@ -Fragments with filenames like `fix-1.2.3.feature` are now associated with the ticket `fix-1.2.3`. -In previous versions they were incorrectly associated to ticket `3`. From 47cf0f3b1d5f4be082fbddbad9b945274eb4d6bb Mon Sep 17 00:00:00 2001 From: Adi Roiban Date: Tue, 7 Nov 2023 16:31:32 +0000 Subject: [PATCH 2/5] Show release draft as a step output. --- .github/workflows/ci.yml | 10 +++++++--- noxfile.py | 5 +++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6546298e..a5467106 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -160,10 +160,12 @@ jobs: python-version: '3.11' task: - name: Check Newsfragment - nox: check_newsfragment + run: | + nox -e check_newsfragment + nox -e draft_newsfragment >> $GITHUB_STEP_SUMMARY run-if: ${{ github.head_ref != 'pre-commit-ci-update-config' }} - name: Check mypy - nox: typecheck + run: nox -e typecheck run-if: true steps: @@ -187,7 +189,9 @@ jobs: - uses: twisted/python-info-action@v1 - - run: nox -e ${{ matrix.task.nox }} + - name: Check + run: | + ${{ matrix.task.run }} if: ${{ matrix.task.run-if }} diff --git a/noxfile.py b/noxfile.py index bcd7f4ef..081817a7 100644 --- a/noxfile.py +++ b/noxfile.py @@ -53,6 +53,11 @@ def check_newsfragment(session: nox.Session) -> None: session.install(".") session.run("python", "-m", "towncrier.check", "--compare-with", "origin/trunk") +@nox.session +def draft_newsfragment(session: nox.Session) -> None: + session.install(".") + session.run("python", "-m", "towncrier.build", "--draft") + @nox.session def typecheck(session: nox.Session) -> None: From bdb1d080e40babc7da54d3f6def37862d0cdcb94 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 7 Nov 2023 16:32:49 +0000 Subject: [PATCH 3/5] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- noxfile.py | 1 + 1 file changed, 1 insertion(+) diff --git a/noxfile.py b/noxfile.py index 081817a7..d3e7d025 100644 --- a/noxfile.py +++ b/noxfile.py @@ -53,6 +53,7 @@ def check_newsfragment(session: nox.Session) -> None: session.install(".") session.run("python", "-m", "towncrier.check", "--compare-with", "origin/trunk") + @nox.session def draft_newsfragment(session: nox.Session) -> None: session.install(".") From 503b499a1ddb13d6c526e5d5511767e53d809e68 Mon Sep 17 00:00:00 2001 From: Adi Roiban Date: Wed, 8 Nov 2023 14:21:07 +0000 Subject: [PATCH 4/5] Update final version. --- NEWS.rst | 7 +++++-- src/towncrier/_version.py | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index e732978f..70db8733 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -5,8 +5,11 @@ Release notes .. towncrier release notes start -towncrier 23.11.0rc1 (2023-11-07) -================================= +towncrier 23.11.0 (2023-11-08) +============================== + +No significant changes since the previous release candidate. + Bugfixes -------- diff --git a/src/towncrier/_version.py b/src/towncrier/_version.py index 7feac3f9..4044ca36 100644 --- a/src/towncrier/_version.py +++ b/src/towncrier/_version.py @@ -11,7 +11,7 @@ # For dev - Version('towncrier', 23, 8, 1, dev=0) # For RC - Version('towncrier', 23, 9, 0, release_candidate=1) # For final - Version('towncrier', 23, 9, 0) -__version__ = Version("towncrier", 23, 11, 0, release_candidate=1) +__version__ = Version("towncrier", 23, 11, 0) # The version is exposed in string format to be # available for the hatching build tools. _hatchling_version = __version__.short() From 8fb0d8ab56d4f726cfd5e0c5975d4aa1c34582bc Mon Sep 17 00:00:00 2001 From: Adi Roiban Date: Wed, 8 Nov 2023 14:32:19 +0000 Subject: [PATCH 5/5] Update dev version. --- src/towncrier/_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/towncrier/_version.py b/src/towncrier/_version.py index 4044ca36..020bb62e 100644 --- a/src/towncrier/_version.py +++ b/src/towncrier/_version.py @@ -11,7 +11,7 @@ # For dev - Version('towncrier', 23, 8, 1, dev=0) # For RC - Version('towncrier', 23, 9, 0, release_candidate=1) # For final - Version('towncrier', 23, 9, 0) -__version__ = Version("towncrier", 23, 11, 0) +__version__ = Version("towncrier", 23, 11, 1, dev=0) # The version is exposed in string format to be # available for the hatching build tools. _hatchling_version = __version__.short()