Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Lantern brightness config option #7

Open
533kr opened this issue Oct 14, 2024 · 5 comments
Open

[Feature request] Lantern brightness config option #7

533kr opened this issue Oct 14, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@533kr
Copy link

533kr commented Oct 14, 2024

Not sure how much of a pain in the ass this would be, but would it be possible to include some sort of config option for lantern brightness? I'm really loving the visual swinging lantern effect, but in my game the light is VERY dim, maybe half of what a handheld lantern puts out.

@txnitxnichopper
Copy link
Member

it shouldn't actually be dim -- it should be giving off 15 light level. I do want to make that configurable though, that's easy to do.

@txnitxnichopper txnitxnichopper added the enhancement New feature or request label Oct 15, 2024
@533kr
Copy link
Author

533kr commented Oct 22, 2024

Sorry for the delay--I grabbed a video showing what I'm seeing when I equip one versus the normal held brightness. There's probably some other mod causing problems, I have a huge list, but I figured I ought to let you know!

bandicam.2024-10-22.05-40-18-210.mp4

It's definitely working, the lantern shows up and has nice physics, it DOES put out light...just very dimly.

@txnitxnichopper
Copy link
Member

it does look like you have some other mod affecting lantern brightness, since it appears to be flickering

@FaNt4zMa
Copy link

Side note slightly unrelated: The soul lantern emits the same brightness as the regular lantern when equipped, which is not the case when holding it.

@533kr
Copy link
Author

533kr commented Oct 30, 2024

The flickering is a shader setting, it shouldn't and generally doesn't effect the actual brightness of objects in this way. It could definitely be interacting strangely with this mod specifically, but it's Complementary Unbound + Euphoria patches (so not a super-niche shader selection) and so far this mod is the only wearable lantern mod that's had this issue. Other mods that add belt lanterns via trinkets slots retain the same brightness as when they're held.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants