Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out the interplay between recursion and issue reporting #110

Open
mniip opened this issue Jul 20, 2021 · 0 comments
Open

Figure out the interplay between recursion and issue reporting #110

mniip opened this issue Jul 20, 2021 · 0 comments

Comments

@mniip
Copy link
Member

mniip commented Jul 20, 2021

Currently during fixpoint finding we blindly substitute Result (meaning "ok") into the formula, and if any issues arose we blindly assume that they are the same issue that would be rethrown if we substituted them into the formula. However in presence of mapErrors that condition can be violated.

Furthermore we do violate this condition because when we memoize compatibility, we rethrow the errors with the appropriate behaviors, so a recursively thrown compatibility issue would have a different behavior on it. A recursive structure thus could have an infinite number of errors with progressively deeper and deeper behaviors.

We should figure out a consistent choice of what we do in this situation, document it and make sure it's implemented correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant