Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6 release: the last major? #1572

Open
NullVoxPopuli opened this issue Oct 10, 2023 · 6 comments
Open

v6 release: the last major? #1572

NullVoxPopuli opened this issue Oct 10, 2023 · 6 comments

Comments

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Oct 10, 2023

Remaining todos here #1568

(most of this is documentation tho, and non-breaking)


Keeping track of changes here for the changelog, tho it does seem like release-it is set up, so this'll all probably be automatic:

Breaking

Enhancements

Fixes

Dependencies

@Polve
Copy link

Polve commented Oct 20, 2023

I comment here to avoid opening a new ticket since I've a couple questions that seem vaguely related.

  1. in the ember-cli-typescript documentation I read:

Ember makes heavy use of decorators, and TypeScript does not currently support deriving type information from decorators.

But in reading ts 5.2 release notes I see they've added support for decorator metadata: is that related and meaning that section will be obsolete in time?

  1. I created a new ember typescript project (ember new prj --typescript) with ember-cli 5.3 and this addon is not installed by default: do I need to add it manually?

I apologize in advance if my questions are very dumb since I'm a total newbie in ember.

@chriskrycho
Copy link
Member

@Polve good questions, but better served by opening a Discussion, so please move there! Thanks!

@Techn1x
Copy link

Techn1x commented Nov 15, 2023

Would it be possible to release the loosened ember-cli-babel version check as a v5 patch rather than as part of the v6 major? Or too much work to split it out for little gain?

I ask because my application has dropped ember-cli-typescript, but I still see the message due to addon dependencies on ember-cli-typescript v5. I imagine those addons are probably not likely to update to v6 and are more likely to drop it instead (as they should). But if they do neither a patch version will mean consumers can at least get rid of the warning message without needing to use overrides/resolutions

@NullVoxPopuli
Copy link
Collaborator Author

I tried just.. getting CI passing.. and it's hard idk what incantations are needed atm. I'd (personally) prefer someone release current main (which already has the ec-babel fix, iirc) without trying to get CI green.

@Techn1x
Copy link

Techn1x commented Jan 23, 2024

Are you able to lend aid @chriskrycho ?

Based on the opening comment, it seems like all the necessary changes have been made, we just need to get releases happening

@chasegiunta
Copy link

Also looking for a release here 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants