Use toList in seq traverse, not vector

valencik · valencik · commit a62ce4c55f31 · 2024-03-22T09:28:24.000-04:00
diff --git a/core/src/main/scala/cats/instances/seq.scala b/core/src/main/scala/cats/instances/seq.scala
@@ -131,7 +131,7 @@ trait SeqInstances extends cats.kernel.instances.SeqInstances {
           case x: StackSafeMonad[G] =>
             x.map(Traverse.traverseDirectly(fa)(f)(x))(_.toList)
           case _ =>
-            G.map(Chain.traverseViaChain(fa.toIndexedSeq)(f))(_.toVector)
+            G.map(Chain.traverseViaChain(fa.toIndexedSeq)(f))(_.toList)
         }
 
       override def traverse_[G[_], A, B](fa: Seq[A])(f: A => G[B])(implicit G: Applicative[G]): G[Unit] =

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ trait SeqInstances extends cats.kernel.instances.SeqInstances {`
`131`	`131`	`case x: StackSafeMonad[G] =>`
`132`	`132`	`x.map(Traverse.traverseDirectly(fa)(f)(x))(_.toList)`
`133`	`133`	`case _ =>`
`134`		`- G.map(Chain.traverseViaChain(fa.toIndexedSeq)(f))(_.toVector)`
	`134`	`+ G.map(Chain.traverseViaChain(fa.toIndexedSeq)(f))(_.toList)`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`override def traverse_[G[_], A, B](fa: Seq[A])(f: A => G[B])(implicit G: Applicative[G]): G[Unit] =`