Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lagom bundle causing deprecated crypto warning #283

Open
fsat opened this issue Dec 10, 2017 · 0 comments
Open

Lagom bundle causing deprecated crypto warning #283

fsat opened this issue Dec 10, 2017 · 0 comments

Comments

@fsat
Copy link
Contributor

fsat commented Dec 10, 2017

Lagom bundle is causing deprecated crypto warning due to the -Dplay.crypto.secret system property set in bundle start command:

// The application secret is not used by the Lagom project so the value doesn't really matter.
// Therefore it is save to automatically generate one here. It is necessary though to set the key in prod mode.
val applicationSecret = s"-Dplay.crypto.secret=${hash(s"${name.value}")}"

Important: before working on this fix, follow up the following Play issue:

playframework/playframework#8075

Basically the gist is Play should not enforce the crypto secret being mandatory unless it's actually used. In Lagom's case, the crypto secret is not used.

If relying the fix on Playframework's side, it may occur in Play >= 2.6.8, so a version detection will be necessary as Play <= 2.6.7 will continue to enforce the crypto secret being mandatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant