Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting collections with special characters doesn't work #194

Open
bfritscher opened this issue Feb 12, 2024 · 1 comment
Open

Deleting collections with special characters doesn't work #194

bfritscher opened this issue Feb 12, 2024 · 1 comment

Comments

@bfritscher
Copy link
Contributor

Description

If I create a collection with a "+" in the name I can no longer interact with it. In Api call which use the collection name in the URL part.

It looks as if there is no escaping happening when building URLs for the typesense API

Does the user of this library need to escape the collection name before using the api and make assumption about the underlaying workings of the api?

Steps to reproduce

  • Add a collection named "foo+bar" with a a dummy field
  • Try to delete the collection

Expected Behavior

  • is urlencoded to make api call work

Actual Behavior

String is used as is and server receives "foo bar"

Metadata

Typesense-js Version: 1.7.2

Reported via bfritscher/typesense-dashboard#44

@LewisW
Copy link
Contributor

LewisW commented Jun 10, 2024

Same with # which opens up malicious actors to deleting unauthorised rows when combined with badly designed IDs/validation.

In fact, one could delete an entire collection just by starting the document ID with a hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants