Skip to content

Commit 332996a

Browse files
committed
fix: multilingual
1 parent 3832805 commit 332996a

File tree

7 files changed

+16
-15
lines changed

7 files changed

+16
-15
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ repositories {
1414
}
1515
1616
dependencies {
17-
implementation 'io.typst:command-bukkit:3.1.5'
17+
implementation 'io.typst:command-bukkit:3.1.6'
1818
}
1919
```
2020

@@ -24,7 +24,7 @@ dependencies {
2424
<dependency>
2525
<groupId>io.typst</groupId>
2626
<artifactId>command-bukkit</artifactId>
27-
<version>3.1.5</version>
27+
<version>3.1.6</version>
2828
</dependency>
2929
```
3030

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ tasks.register("publishCentralPortal") {
2020

2121
allprojects {
2222
group 'io.typst'
23-
version '3.1.5'
23+
version '3.1.6'
2424
def moduleName = name.substring(name.indexOf('-') + 1)
2525
ext.registerPublish = {
2626
publishing {

bukkit/src/main/java/io/typst/command/bukkit/BukkitCommands.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public static <A> List<String> tabComplete(CommandSender sender, String[] args,
117117
*/
118118
static <A> List<String> getCommandUsages(CommandSender sender, String label, String[] args, int position, Command<A> cmd, BukkitCommandConfig config) {
119119
Player player = sender instanceof Player ? ((Player) sender) : null;
120-
String locale = player != null ? player.getLocale() : Locale.getDefault().getLanguage().split("_")[0].toLowerCase();
120+
String locale = player != null ? player.getLocale() : Locale.getDefault().toString().toLowerCase();
121121
Function<BukkitCommandHelp, String> formatter = config.getFormatter();
122122
String[] succArgs = args.length >= 1
123123
? Arrays.copyOfRange(args, 0, position)
@@ -156,7 +156,7 @@ private static <A> List<String> getFailureMessage(CommandSender sender, String l
156156
List<String> usages = new ArrayList<>(getCommandUsages(
157157
sender, label, unknown.getArguments(), unknown.getIndex(), unknown.getCommand(), config
158158
));
159-
if (locale.equals("ko")) {
159+
if (locale.equals("ko_kr")) {
160160
usages.add(String.format("'%s' 명령어는 존재하지 않습니다!", input));
161161
} else {
162162
usages.add(String.format("Command '%s' doesn't exists!", input));
@@ -166,13 +166,13 @@ private static <A> List<String> getFailureMessage(CommandSender sender, String l
166166
CommandFailure.ParsingFailure<A> parsingFailure = (CommandFailure.ParsingFailure<A>) failure;
167167
List<String> usages = new ArrayList<>();
168168
usages.addAll(getCommandUsages(sender, label, parsingFailure.getArguments(), parsingFailure.getIndex(), parsingFailure.getCommand(), config));
169-
String message = locale.equals("ko")
169+
String message = locale.equals("ko_kr")
170170
? "잘못된 명령어입니다!"
171171
: "Wrong command!";
172172
usages.add(message);
173173
return usages;
174174
}
175-
String message = locale.equals("ko")
175+
String message = locale.equals("ko_kr")
176176
? "잘못된 명령어입니다!"
177177
: "Wrong command!";
178178
return Collections.singletonList(message);

bukkit/src/main/java/io/typst/command/bukkit/BukkitControlFlows.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public static Player getPlayerOrThrow(CommandSender sender) {
2222
if (sender instanceof Player) {
2323
return ((Player) sender);
2424
} else {
25-
String message = Locale.getDefault().getLanguage().equals("ko")
25+
String message = Locale.getDefault().getLanguage().equals("ko_kr")
2626
? "§c게임에 접속해서 사용해주세요!"
2727
: "§cIngame player only!";
2828
throw new CommandCancellationException(message);
@@ -34,7 +34,7 @@ public static ItemStack getHandItemOrThrow(Player player) {
3434
if (handItem != null && handItem.getType() != Material.AIR) {
3535
return handItem;
3636
}
37-
String message = Locale.getDefault().getLanguage().equals("ko")
37+
String message = Locale.getDefault().getLanguage().equals("ko_kr")
3838
? "§c손에 아이템을 들어주세요!"
3939
: "§cPlease hold an item on your main hand!";
4040
throw new CommandCancellationException(message);
@@ -43,7 +43,7 @@ public static ItemStack getHandItemOrThrow(Player player) {
4343
static void validatePermission(Command<?> node, CommandSender sender) {
4444
String perm = CommandSpec.from(node).getPermission();
4545
if (!perm.isEmpty() && !sender.hasPermission(perm)) {
46-
String message = Locale.getDefault().getLanguage().equals("ko")
46+
String message = Locale.getDefault().getLanguage().equals("ko_kr")
4747
? "§c권한이 없습니다! `" + perm + "`"
4848
: "§cNo permission! `" + perm + "`";
4949
throw new CommandCancellationException(message);

bukkit/src/test/java/io/typst/command/bukkit/CommandTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class CommandTest {
3333
@Test
3434
public void help() {
3535
StringBuilder output = new StringBuilder();
36-
MockPlayer player = new MockPlayer(new MockSender(output), "ko", UUID.randomUUID());
36+
MockPlayer player = new MockPlayer(new MockSender(output), "ko_kr", UUID.randomUUID());
3737
List<String> msgs = BukkitCommands.getCommandUsages(
3838
player,
3939
"mycmd",
@@ -57,7 +57,7 @@ public void help() {
5757
@Test
5858
public void helpFallback() {
5959
StringBuilder output = new StringBuilder();
60-
MockPlayer player = new MockPlayer(new MockSender(output), "ko", UUID.randomUUID());
60+
MockPlayer player = new MockPlayer(new MockSender(output), "ko_kr", UUID.randomUUID());
6161
List<String> msgs = BukkitCommands.getCommandUsages(
6262
player,
6363
"mycmd",
@@ -77,7 +77,7 @@ public void helpFallback() {
7777
@Test
7878
public void helpSingle() {
7979
StringBuilder output = new StringBuilder();
80-
MockPlayer player = new MockPlayer(new MockSender(output), "ko", UUID.randomUUID());
80+
MockPlayer player = new MockPlayer(new MockSender(output), "ko_kr", UUID.randomUUID());
8181
BukkitCommands.execute(player, "mycmd", new String[]{"d"}, command, BukkitCommandConfig.empty);
8282
Assertions.assertEquals(" \n/mycmd d (문자열) (정수) - desc\n잘못된 명령어입니다!\n", output.toString());
8383
System.out.println(output);
@@ -86,7 +86,7 @@ public void helpSingle() {
8686
@Test
8787
public void tabCompleteOnArgThatNoPermission() {
8888
StringBuilder output = new StringBuilder();
89-
MockPlayer player = new MockPlayer(new MockSender(output), "ko", UUID.randomUUID());
89+
MockPlayer player = new MockPlayer(new MockSender(output), "ko_kr", UUID.randomUUID());
9090
List<String> completes = BukkitCommands.tabComplete(player, new String[]{"f", ""}, command, (sender, x) -> Collections.emptyList());
9191
Assertions.assertEquals(Collections.emptyList(), completes);
9292
}

core/src/main/java/io/typst/command/CommandConfig.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
@Value(staticConstructor = "of")
99
@With
1010
public class CommandConfig {
11+
// TODO: data instead of function
1112
Function<CommandHelp, String> formatter;
1213
boolean hideNoPermissionCommands;
1314
public static final CommandConfig empty = new CommandConfig(CommandHelp::format, true);

core/src/main/java/io/typst/command/CommandHelp.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public static String format(CommandHelp help) {
2121
List<String> args = help.getArguments();
2222
String argSuffix;
2323
String space = args.isEmpty() ? "" : " ";
24-
if (help.getLanguage().equals("ko")) {
24+
if (help.getLanguage().equals("ko_kr")) {
2525
argSuffix = spec.getArguments().stream().anyMatch(arg -> !arg.getName().isEmpty())
2626
? space + "§e" + spec.getArguments().stream()
2727
.map(s -> String.format("(%s)", translateToKor(s.getName())))

0 commit comments

Comments
 (0)