diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index 7ccb5335b..b35e28506 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -14,94 +14,125 @@ submissions: Breaking Logic into Components: 3 Herbert Joseph: repository: https://github.com/Copywright/mastermind - notes: "Don't kill me..." - evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + notes: "Don't kill me... + Complex code with long methods, but saw logic ____. + Saw map and include?; used .each for generating color sequence (look into better choice enumerable). + Small, encapsulated classes had solid tests, but game_manager was difficult because of too much going on. + Game was pleasant to play, but did not always behave as expected. + Pulled out input, printer, color sequence, and guess checker into small, manageable classes; would like to see game manager separated into objects that perform certain responsibilities. + " + evaluation: + Fundamental Ruby & Style: 2 + Enumerable & Collections: 2.5 + Test-Driven Development: 2.5 + REPL Interface: 2.5 + Breaking Logic into Components: 2.5 Sam Kuhlmann: repository: https://github.com/skuhlmann/turing_mastermind - notes: "" + notes: "Showed effort toward good organization and refactoring. + Saw use of each_with_index, map, count for enumerables. + Small classes well-tested, but missing tests for game logic. + Some rough edges in game play (not major features), but clear and pleasant to play otherwise. + Broke out responsibilities into small classes (timer, code generator, message printer, etc.), but game class could be smaller." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 2.5 + REPL Interface: 2.5 + Breaking Logic into Components: 3 Gregory Narajka: - repository: - notes: "" + repository: https://github.com/gregnar/mastermind.git + notes: "Saw good naming conventions; some long methods with nested loops/case/until statements. + Saw map, each_with_index, count; check use of destructive .map! and chaining each_with_index and count together. + Good use of StringIO for testing input/output. Well-tested in isolation and integration. + Game is easy and pleasant to use; implemented turns and difficulty options. + Encapsulated responsibilities into separate objects (printer, checker, cli, game, sequence generator, color sequence), but would like to see less logic per method (especially with loops and case statements)." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 2.5 + Enumerable & Collections: 3 + Test-Driven Development: 4 + REPL Interface: 4 + Breaking Logic into Components: 3 Kate Lane: - repository: - notes: "" + repository: https://github.com/katelane/mastermind.git + notes: "Good naming conventions; shows effort toward organization and refactoring. + Saw each_with_index and count -- and chained together! :) + Well-tested with guess checker, but missing tests on game, board, and printer. + Couldn't find edge-cases to break REPL. Pleasant to use. + Able to pull board and game apart easily; would like to see case statements pulled out from within methods." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 2 + REPL Interface: 3 + Breaking Logic into Components: 3 Timothy Mee: repository: https://github.com/Tmee/MASTERMIND/tree/take_2 - notes: "and that's that." + notes: "and that's that. + Some methods clean and single-responsibility; others need refactoring. + Saw use of each to iterate. Would like to see enumerables used in place of stacked if statements. + Attempt at testing to get user input but not implemented. + REPL easy to use; clear and easy to play. + Broke apart printer, CLI, and game (run), but Run class included a lot of responsibilities. + " evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 2.5 + Enumerable & Collections: 2 + Test-Driven Development: 1 + REPL Interface: 3 + Breaking Logic into Components: 2 Konr Larson: repository: https://github.com/larsonkonr/mastermind.git - notes: "" + notes: "Game plays well. Good use of colors. Needs tests!!! Some weak spots + in enumerable usage and if/else vs unless vs case." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 2 + Enumerable & Collections: 2 + Test-Driven Development: 1 + REPL Interface: 4 + Breaking Logic into Components: 3 Zachary Routhier: repository: https://github.com/zRouth/Mastermind.git - notes: "" + notes: "Game plays well. Separate files out to subfolders (lib, test). Nine + tests total, they pass. Get rid of dead code/files." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 1 + REPL Interface: 3 + Breaking Logic into Components: 3 David Bayendor: repository: git@github.com:bayendor/mastermind.git - notes: "" + notes: "Game plays well. Decent job of testing (w/ 17 tests). Many good + unit tests, need some tests at a higher level that imitate the user. + Ruby uses small methods, simple code, solid Ruby API. Pull some + responsibilities like sequence generation out into their own classes." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 2 + REPL Interface: 3 + Breaking Logic into Components: 2 Adam Smith: repository: - notes: "" + notes: "Doesn't quite follow spec for the game. Really no tests. Code works + but is difficult to follow/read. Work on breaking out components." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 2 + Enumerable & Collections: 2 + Test-Driven Development: 1 + REPL Interface: 3 + Breaking Logic into Components: 2 Christopher Bynum: repository: - notes: "" + notes: "Game plays well. About 36 tests across six files. Ruby is very good, + shows effort in refactoring. Love how things are divided up." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 4 + REPL Interface: 4 + Breaking Logic into Components: 4 Chase van Hekken: repository: https://github.com/ChasevanHekken/mastermind-game.git notes: "Definitely shows a growing grasp of OO concepts and idiomatic Ruby. @@ -148,7 +179,9 @@ submissions: Danny Glunz: repository: notes: "Completed both Mastermind and Battleship. - Lacking sufficient test coverage." + Lacking sufficient test coverage. + Excellent REPL interface; included game board. + Packed as a gem (`gem install mastermind-dglunz`)" evaluation: Fundamental Ruby & Style: 4 Enumerable & Collections: 4 @@ -157,7 +190,8 @@ submissions: Breaking Logic into Components: 3.5 Chandra Carney: repository: - notes: "Lacking test coverage. + notes: "Lacking test coverage --- needs more tests. + Broke out several components into their own classes. Good use of enumerable and Ruby style." evaluation: Fundamental Ruby & Style: 3 diff --git a/blogging/2014-09-26.markdown b/blogging/2014-09-26.markdown new file mode 100644 index 000000000..fc045e6d6 --- /dev/null +++ b/blogging/2014-09-26.markdown @@ -0,0 +1,38 @@ +Add your post's production URL below: + +## The Pivot Project Posts + +* TravelHome: +* Airlift: +* EmployMe: +* Keevahh: + +## Individual Posts + +* Aaron Paul Wortham: +* Adam Smith: +* Alex Jensen: +* Cara Dennis: +* Chandra Carney: +* Chase van Hekken: +* Christopher Bynum: +* Danny Glunz: +* David Bayendor: +* Glen Egbert: +* Gregory Narajka: +* Herbert Joseph: +* Ian Andersen: +* Jessica Goulding: +* Jim Sutton: +* Kalah Cheek: +* Kate Lane: +* Kavita Sachdeva: +* Konr Josef Laron: +* Luke Aiken: +* Rolando Navarrete: +* Sam Kuhlmann: +* Sara Simon: +* Timothy Mee: +* Travis Yoder: +* Victoria Harrod: +* Zachary Routhier: