From e489781d2cb864fca40157d630cc1a3b4038fef3 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Thu, 25 Sep 2014 13:29:28 -0600 Subject: [PATCH 01/11] Add Konr's eval --- 1409/01_mastermind/mastermind_submissions.yml | 31 ++++++++++--------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index bff3922f7..9f5a1f6e7 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -27,7 +27,7 @@ submissions: REPL Interface: 0 Breaking Logic into Components: 0 Gregory Narajka: - repository: + repository: notes: "" evaluation: Fundamental Ruby & Style: 0 @@ -36,7 +36,7 @@ submissions: REPL Interface: 0 Breaking Logic into Components: 0 Kate Lane: - repository: + repository: notes: "" evaluation: Fundamental Ruby & Style: 0 @@ -55,13 +55,14 @@ submissions: Breaking Logic into Components: 0 Konr Larson: repository: https://github.com/larsonkonr/mastermind.git - notes: "" - evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + notes: "Game plays well. Good use of colors. Needs tests!!! Some weak spots + in enumerable usage and if/else vs unless vs case." + evaluation: + Fundamental Ruby & Style: 2 + Enumerable & Collections: 2 + Test-Driven Development: 1 + REPL Interface: 4 + Breaking Logic into Components: 3 Zachary Routhier: repository: https://github.com/zRouth/Mastermind.git notes: "" @@ -81,7 +82,7 @@ submissions: REPL Interface: 0 Breaking Logic into Components: 0 Adam Smith: - repository: + repository: notes: "" evaluation: Fundamental Ruby & Style: 0 @@ -90,7 +91,7 @@ submissions: REPL Interface: 0 Breaking Logic into Components: 0 Christopher Bynum: - repository: + repository: notes: "" evaluation: Fundamental Ruby & Style: 0 @@ -108,7 +109,7 @@ submissions: REPL Interface: 0 Breaking Logic into Components: 0 Victoria Harrod: - repository: + repository: notes: "" evaluation: Fundamental Ruby & Style: 0 @@ -126,7 +127,7 @@ submissions: REPL Interface: 0 Breaking Logic into Components: 0 Travis Yoder: - repository: + repository: notes: "" evaluation: Fundamental Ruby & Style: 0 @@ -135,7 +136,7 @@ submissions: REPL Interface: 0 Breaking Logic into Components: 0 Danny Glunz: - repository: + repository: notes: "" evaluation: Fundamental Ruby & Style: 0 @@ -144,7 +145,7 @@ submissions: REPL Interface: 0 Breaking Logic into Components: 0 Chandra Carney: - repository: + repository: notes: "" evaluation: Fundamental Ruby & Style: 0 From cbc600b133a7ec70f653b730dae525fa1e7fece7 Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 25 Sep 2014 14:07:04 -0600 Subject: [PATCH 02/11] Update mastermind_submissions.yml --- 1409/01_mastermind/mastermind_submissions.yml | 20 ++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index 685914534..71eef8dd7 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -14,13 +14,19 @@ submissions: Breaking Logic into Components: 3 Herbert Joseph: repository: https://github.com/Copywright/mastermind - notes: "Don't kill me..." - evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + notes: "Don't kill me... + Complex code with long methods, but saw logic ____. + Saw map and include?; used .each for generating color sequence (look into better choice enumerable). + Small, encapsulated classes had solid tests, but game_manager was difficult because of too much going on. + Game was pleasant to play, but did not always behave as expected. + Pulled out input, printer, color sequence, and guess checker into small, manageable classes; would like to see game manager separated into objects that perform certain responsibilities. + " + evaluation: + Fundamental Ruby & Style: 2 + Enumerable & Collections: 2.5 + Test-Driven Development: 2.5 + REPL Interface: 2.5 + Breaking Logic into Components: 2.5 Sam Kuhlmann: repository: https://github.com/skuhlmann/turing_mastermind notes: "" From 87ce1fb9ca94da484ef2d070c736750452bd5677 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Thu, 25 Sep 2014 14:28:04 -0600 Subject: [PATCH 03/11] Zach & David evals --- 1409/01_mastermind/mastermind_submissions.yml | 30 +++++++++++-------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index 9f5a1f6e7..8d6831608 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -65,22 +65,26 @@ submissions: Breaking Logic into Components: 3 Zachary Routhier: repository: https://github.com/zRouth/Mastermind.git - notes: "" + notes: "Game plays well. Separate files out to subfolders (lib, test). Nine + tests total, they pass. Get rid of dead code/files." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 1 + REPL Interface: 3 + Breaking Logic into Components: 3 David Bayendor: repository: git@github.com:bayendor/mastermind.git - notes: "" - evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + notes: "Game plays well. Decent job of testing (w/ 17 tests). Many good + unit tests, need some tests at a higher level that imitate the user. + Ruby uses small methods, simple code, solid Ruby API. Pull some + responsibilities like sequence generation out into their own classes." + evaluation: + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 2 + REPL Interface: 3 + Breaking Logic into Components: 2 Adam Smith: repository: notes: "" From b53012030c1c98f6259b73178256b4f8f49c6c1e Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 25 Sep 2014 14:34:09 -0600 Subject: [PATCH 04/11] Update mastermind_submissions.yml --- 1409/01_mastermind/mastermind_submissions.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index c08395f60..a2bd73ea7 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -29,13 +29,17 @@ submissions: Breaking Logic into Components: 2.5 Sam Kuhlmann: repository: https://github.com/skuhlmann/turing_mastermind - notes: "" + notes: "Showed effort toward good organization and refactoring. + Saw use of each_with_index, map, count for enumerables. + Small classes well-tested, but missing tests for game logic. + Some rough edges in game play (not major features), but clear and pleasant to play otherwise. + Broke out responsibilities into small classes (timer, code generator, message printer, etc.), but game class could be smaller." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 2.5 + REPL Interface: 2.5 + Breaking Logic into Components: 3 Gregory Narajka: repository: notes: "" From 5fead14fc58e83ebcfef96e69ed42de7607e1a00 Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 25 Sep 2014 15:00:09 -0600 Subject: [PATCH 05/11] Update mastermind_submissions.yml --- 1409/01_mastermind/mastermind_submissions.yml | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index a2bd73ea7..d1977bbf1 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -41,14 +41,18 @@ submissions: REPL Interface: 2.5 Breaking Logic into Components: 3 Gregory Narajka: - repository: - notes: "" - evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + repository: https://github.com/gregnar/mastermind.git + notes: "Saw good naming conventions; some long methods with nested loops/case/until statements. + Saw map, each_with_index, count; check use of destructive .map! and chaining each_with_index and count together. + Good use of StringIO for testing input/output. Well-tested in isolation and integration. + Game is easy and pleasant to use; implemented turns and difficulty options. + Encapsulated responsibilities into separate objects (printer, checker, cli, game, sequence generator, color sequence), but would like to see less logic per method (especially with loops and case statements)." + evaluation: + Fundamental Ruby & Style: 2.5 + Enumerable & Collections: 3 + Test-Driven Development: 4 + REPL Interface: 4 + Breaking Logic into Components: 3 Kate Lane: repository: notes: "" From 5bb81a3d065fb1811257bad4674238b0e9eaa6fa Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Thu, 25 Sep 2014 15:01:01 -0600 Subject: [PATCH 06/11] Eval for Adam --- 1409/01_mastermind/mastermind_submissions.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index c08395f60..448e20957 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -97,13 +97,14 @@ submissions: Breaking Logic into Components: 2 Adam Smith: repository: - notes: "" + notes: "Doesn't quite follow spec for the game. Really no tests. Code works + but is difficult to follow/read. Work on breaking out components." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 2 + Enumerable & Collections: 2 + Test-Driven Development: 1 + REPL Interface: 3 + Breaking Logic into Components: 2 Christopher Bynum: repository: notes: "" From fda39b274012049800e68e81c8cad3ca4aa37665 Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 25 Sep 2014 15:32:38 -0600 Subject: [PATCH 07/11] Update mastermind_submissions.yml --- 1409/01_mastermind/mastermind_submissions.yml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index d1977bbf1..ff3473cd9 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -54,14 +54,18 @@ submissions: REPL Interface: 4 Breaking Logic into Components: 3 Kate Lane: - repository: - notes: "" + repository: https://github.com/katelane/mastermind.git + notes: "Good naming conventions; shows effort toward organization and refactoring. + Saw each_with_index and count -- and chained together! :) + Well-tested with guess checker, but missing tests on game, board, and printer. + Couldn't find edge-cases to break REPL. Pleasant to use. + Able to pull board and game apart easily; would like to see case statements pulled out from within methods." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 2 + REPL Interface: 3 + Breaking Logic into Components: 3 Timothy Mee: repository: https://github.com/Tmee/MASTERMIND/tree/take_2 notes: "and that's that." From f6ca459e8e3841e1b63291ea7ca4c6d82e29f06b Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 25 Sep 2014 16:00:32 -0600 Subject: [PATCH 08/11] Update mastermind_submissions.yml --- 1409/01_mastermind/mastermind_submissions.yml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index ff3473cd9..65165d355 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -68,13 +68,19 @@ submissions: Breaking Logic into Components: 3 Timothy Mee: repository: https://github.com/Tmee/MASTERMIND/tree/take_2 - notes: "and that's that." + notes: "and that's that. + Some methods clean and single-responsibility; others need refactoring. + Saw use of each to iterate. Would like to see enumerables used in place of stacked if statements. + Attempt at testing to get user input but not implemented. + REPL easy to use; clear and easy to play. + Broke apart printer, CLI, and game (run), but Run class included a lot of responsibilities. + " evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 2.5 + Enumerable & Collections: 2 + Test-Driven Development: 1 + REPL Interface: 3 + Breaking Logic into Components: 2 Konr Larson: repository: https://github.com/larsonkonr/mastermind.git notes: "Game plays well. Good use of colors. Needs tests!!! Some weak spots From 9bd2436355e7c07336a962ecac72b0f3b63d46d8 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Fri, 26 Sep 2014 08:48:23 -0600 Subject: [PATCH 09/11] Stub for blogging --- 1409/01_mastermind/mastermind_submissions.yml | 13 +++++++------ blogging/2014-09-26.markdown | 0 2 files changed, 7 insertions(+), 6 deletions(-) create mode 100644 blogging/2014-09-26.markdown diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index 448e20957..2c177a806 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -107,13 +107,14 @@ submissions: Breaking Logic into Components: 2 Christopher Bynum: repository: - notes: "" + notes: "Game plays well. About 36 tests across six files. Ruby is very good, + shows effort in refactoring. Love how things are divided up." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 4 + REPL Interface: 4 + Breaking Logic into Components: 4 Chase van Hekken: repository: https://github.com/ChasevanHekken/mastermind-game.git notes: "" diff --git a/blogging/2014-09-26.markdown b/blogging/2014-09-26.markdown new file mode 100644 index 000000000..e69de29bb From 5c72d0238d334bf372ce0c067e64328800d5153b Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Fri, 26 Sep 2014 09:10:26 -0600 Subject: [PATCH 10/11] Name markers for blog --- blogging/2014-09-26.markdown | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/blogging/2014-09-26.markdown b/blogging/2014-09-26.markdown index e69de29bb..275f21dab 100644 --- a/blogging/2014-09-26.markdown +++ b/blogging/2014-09-26.markdown @@ -0,0 +1,29 @@ +Add your post's production URL below: + +* Aaron Paul Wortham: +* Adam Smith: +* Alex Jensen: +* Cara Dennis: +* Chandra Carney: +* Chase van Hekken: +* Christopher Bynum: +* Danny Glunz: +* David Bayendor: +* Glen Egbert: +* Gregory Narajka: +* Herbert Joseph: +* Ian Andersen: +* Jessica Goulding: +* Jim Sutton: +* Kalah Cheek: +* Kate Lane: +* Kavita Sachdeva: +* Konr Josef Laron: +* Luke Aiken: +* Rolando Navarrete: +* Sam Kuhlmann: +* Sara Simon: +* Timothy Mee: +* Travis Yoder: +* Victoria Harrod: +* Zachary Routhier: From fb9a7dcab7cbbfe8deace15bdda68154a6c05f07 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Fri, 26 Sep 2014 09:11:23 -0600 Subject: [PATCH 11/11] Pivot markers --- blogging/2014-09-26.markdown | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/blogging/2014-09-26.markdown b/blogging/2014-09-26.markdown index 275f21dab..fc045e6d6 100644 --- a/blogging/2014-09-26.markdown +++ b/blogging/2014-09-26.markdown @@ -1,5 +1,14 @@ Add your post's production URL below: +## The Pivot Project Posts + +* TravelHome: +* Airlift: +* EmployMe: +* Keevahh: + +## Individual Posts + * Aaron Paul Wortham: * Adam Smith: * Alex Jensen: