From 4d15c306880033c2fa682602febea69a89813178 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Thu, 14 Aug 2014 09:47:52 -0600 Subject: [PATCH 1/5] Eval for Glen and Luke --- .../event_reporter_submissions.yml | 20 ++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/1407/02_event_reporter/event_reporter_submissions.yml b/1407/02_event_reporter/event_reporter_submissions.yml index 61bc62454..6f72a1696 100644 --- a/1407/02_event_reporter/event_reporter_submissions.yml +++ b/1407/02_event_reporter/event_reporter_submissions.yml @@ -21,14 +21,20 @@ submissions: Enumerable & Collections: 0 Luke Aiken and Glen Egbert: repository: Luke: https://github.com/lukeaiken/event_reporter, Glen: https://github.com/glenegbert/mastermind.git - notes: "" + notes: "Some test cases execute properly. + Good implementation of fundamental finding, printing. + Doesn't handle some edge cases. + Tests don't run, needs better coverage. + Decomposition is good. + Ruby is overall strong, but tries to do too much in places. + Good use of enumerable methods." evaluation: - Functional Expectations: 0 - REPL Interface: 0 - Test-Driven Development: 0 - Breaking Logic into Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 + Functional Expectations: 1 + REPL Interface: 3 + Test-Driven Development: 1.5 + Breaking Logic into Components: 3 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 Jessica Goulding and Rolando Navarette: repository:https://github.com/JessicaG/event_reporter_rj notes: "" From eda95f3323b1f8081a47997388fb0073788b6cd8 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Thu, 14 Aug 2014 10:31:35 -0600 Subject: [PATCH 2/5] Eval for Aaron & Cara --- .../event_reporter_submissions.yml | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/1407/02_event_reporter/event_reporter_submissions.yml b/1407/02_event_reporter/event_reporter_submissions.yml index 6f72a1696..f5763a10f 100644 --- a/1407/02_event_reporter/event_reporter_submissions.yml +++ b/1407/02_event_reporter/event_reporter_submissions.yml @@ -47,11 +47,18 @@ submissions: Enumerable & Collections: 0 Cara Dennis and Aaron Paul Wortham: repository: git@github.com:objectParadigm/event-reporter.git - notes: "" + notes: "Some small deviations from the spec instructions. + Save outputs good data but misses headers, so re-load won't work. + Emptiness story won't work because data is autoloaded. + Bummer that some tests/code got lost up git creek. + Good Ruby structures and style. + Watch out for little debugging bits lingering around. + Ruby shows good style and care. + Good use of several enumerable techniques." evaluation: - Functional Expectations: 0 - REPL Interface: 0 - Test-Driven Development: 0 - Breaking Logic into Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 + Functional Expectations: 2 + REPL Interface: 3 + Test-Driven Development: 2 + Breaking Logic into Components: 3 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 From 15317321ad87fe951f24c9af3079f9adfd4c5394 Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 14 Aug 2014 10:38:28 -0600 Subject: [PATCH 3/5] Update event_reporter_submissions.yml --- .../event_reporter_submissions.yml | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/1407/02_event_reporter/event_reporter_submissions.yml b/1407/02_event_reporter/event_reporter_submissions.yml index f5763a10f..d4bfb1b70 100644 --- a/1407/02_event_reporter/event_reporter_submissions.yml +++ b/1407/02_event_reporter/event_reporter_submissions.yml @@ -37,14 +37,17 @@ submissions: Enumerable & Collections: 3 Jessica Goulding and Rolando Navarette: repository:https://github.com/JessicaG/event_reporter_rj - notes: "" + notes: "Crashes during find w/o load and reloading CSV. + Good use of best-choice enumerables. + Decent separation of logic -- confusion with CLI and UserCommand class. + For Fundamental Ruby & Style -- looks mostly good, but app crashes because errors are not handled." evaluation: - Functional Expectations: 0 - REPL Interface: 0 - Test-Driven Development: 0 - Breaking Logic into Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 + Functional Expectations: 2 + REPL Interface: 4 + Test-Driven Development: 3 + Breaking Logic into Components: 3 + Fundamental Ruby & Style: 2 + Enumerable & Collections: 4 Cara Dennis and Aaron Paul Wortham: repository: git@github.com:objectParadigm/event-reporter.git notes: "Some small deviations from the spec instructions. From d69fbdaad35124f81d0e6cc93a549d3fd401ea45 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Thu, 14 Aug 2014 11:25:10 -0600 Subject: [PATCH 4/5] Eval for Kavita & Ian --- .../event_reporter_submissions.yml | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/1407/02_event_reporter/event_reporter_submissions.yml b/1407/02_event_reporter/event_reporter_submissions.yml index f5763a10f..849ae56cd 100644 --- a/1407/02_event_reporter/event_reporter_submissions.yml +++ b/1407/02_event_reporter/event_reporter_submissions.yml @@ -11,14 +11,19 @@ submissions: Enumerable & Collections: 0 Kavita Sachdeva and Ian Andersen: repository: git@github.com:ianderse/event_reporter.git - notes: "" + notes: "Most example stories work well. + Initially got rejected trying to save the file. + One crash in the emptiness story. + Testing and decomposition are well done. + Code shows good effort towards readability. + " evaluation: - Functional Expectations: 0 - REPL Interface: 0 - Test-Driven Development: 0 - Breaking Logic into Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 + Functional Expectations: 2 + REPL Interface: 3 + Test-Driven Development: 3 + Breaking Logic into Components: 4 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 Luke Aiken and Glen Egbert: repository: Luke: https://github.com/lukeaiken/event_reporter, Glen: https://github.com/glenegbert/mastermind.git notes: "Some test cases execute properly. From b76690250850e3fe92315260dedb0d284aca5c02 Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 14 Aug 2014 12:03:31 -0600 Subject: [PATCH 5/5] Update event_reporter_submissions.yml --- .../event_reporter_submissions.yml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/1407/02_event_reporter/event_reporter_submissions.yml b/1407/02_event_reporter/event_reporter_submissions.yml index 88053471d..0a1c24249 100644 --- a/1407/02_event_reporter/event_reporter_submissions.yml +++ b/1407/02_event_reporter/event_reporter_submissions.yml @@ -1,14 +1,16 @@ submissions: Jim Sutton and Sara Simon: repository: https://github.com/a6ftcruton/event_reporter.git - notes: "" + notes: "Tests present, but minimally functional. + TDD strong at beginning of project, but tests didn't work after last-minute changes were made. + Missing some functionality (print by and correctly-formatted CSV)." evaluation: - Functional Expectations: 0 - REPL Interface: 0 - Test-Driven Development: 0 - Breaking Logic into Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 + Functional Expectations: 2 + REPL Interface: 3 + Test-Driven Development: 2 + Breaking Logic into Components: 3.5 + Fundamental Ruby & Style: 2.5 + Enumerable & Collections: 3.5 Kavita Sachdeva and Ian Andersen: repository: git@github.com:ianderse/event_reporter.git notes: "Most example stories work well.