diff --git a/1407/04_clone_wars/clone_wars_submissions.yml b/1407/04_clone_wars/clone_wars_submissions.yml index 1a3cb200b..b511e4ef2 100644 --- a/1407/04_clone_wars/clone_wars_submissions.yml +++ b/1407/04_clone_wars/clone_wars_submissions.yml @@ -5,26 +5,37 @@ submissions: repository: "git@github.com:objectParadigm/jimmys-urban-bar-and-grill.git" setup_notes: "" instructor_evaluation: - notes: "" + notes: "all base expectations fulfilled; added one interactive element. + admin menu able to be edited w/o being logged in as administrator. + some acceptance tests (creating user, creating menu items), but unit tests missing. + used all http verbs; some mixing of web & business logic. + views used layouts and partials to avoid code replication. + many concerns about order of lessons and lack of important concepts in lessons." rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Sinatra / Web and Business Logic: 0 - View Layer: 0 + Functional Expectations: 3 + Test-Driven Development: 2 + Encapsulation / Components: 2.5 + Fundamental Ruby & Style: 2.5 + Sinatra / Web and Business Logic: 3 + View Layer: 3.5 "Sara Simon & Ian Andersen & Glen Egbert": repository: "git@github.com:ianderse/clone_wars.git" setup_notes: "" instructor_evaluation: - notes: "" + notes: "recreated original site; added banner, contact, reservation, and reviews. + admin able to edit items (name, size, price, image). + saw good testing at feature level; would like to see more things tested in isolation. + good divisions of logic and encapsulation; content store probably could have been broken into a repository and a seracher. + easy to read and follow code. + saw use of layout and partials to avoid code duplication; did not see use of helpers. + " rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Sinatra / Web and Business Logic: 0 - View Layer: 0 + Functional Expectations: 4 + Test-Driven Development: 2 + Encapsulation / Components: 3.5 + Fundamental Ruby & Style: 4 + Sinatra / Web and Business Logic: 3.5 + View Layer: 3.5 "Jessica Goulding & Luke Aiken & Aaron Paul Wortham": repository: "https://github.com/JessicaG/slice_works_clone" setup_notes: ""