diff --git a/1406/05_dinner_dash/dinner_dash_submissions.yml b/1406/05_dinner_dash/dinner_dash_submissions.yml new file mode 100644 index 000000000..bc6ca7edc --- /dev/null +++ b/1406/05_dinner_dash/dinner_dash_submissions.yml @@ -0,0 +1,88 @@ +# NOTE: You can verify that you haven't broken the format with +# $ ruby -rpp -ryaml -e 'pp YAML.load File.read("1406/04_clone_wars/clone_wars_submissions.yml") +submissions: + Andrew Watkins, Jonmichael Chambers, Marc Garreau, Chad Brading: + repository: + setup_notes: "" + instructor_evaluation: + notes: | + Evaluated by Josh + can't log out ;p~~~~~~ + users and accounts are the same thing + nice use of presenters + Good tests in general, tiny bit not covered, but not for a particularly good reason + Can't log out, yo, sharing my cart with mah homies + no link to category + orders "all" counts current order + rubric: + Feature Completeness: 3 + Views: 4 + Controllers: 3 + Models: 4 + TDD: 4- + Usability: 3 + Horacio Chavez, Corey Davis, Tan Doan, Hilary Denton: + repository: + setup_notes: "" + instructor_evaluation: + notes: | + Evaluated by Josh + Feature Completeness + No link to my profile/orders + can see other people's orders + cart is gone forever when I logout :( + Can't edit user info + admin orders missing total + some links to transition that aren't actually available + no Heroku :P + Views + use state machine instead of logic in admin orders view + the logic that was there was wrong + correctly indent the code + find balance between the pristine pages (menu, front page) and the rest + Controllers + lots of dead code + unnecessary json stuff + session helper is better in application controller + need to push knowledge of things like `role == 'admin'` down + Models + TDD + high coverage, if you delete dead code :) + things tested at feature level that would be better at a more focused level + (e.g. I don't want to deal with the internet just to test how long a password can be) + Usability + most of the reasons are documented under features + Unused routes + most pages need aesthetic work + the map doesn't show + rubric: + Feature Completeness: 1.5 + Views: 3 + Controllers: 3 + Models: 3.5 + TDD: 3 + Usability: 2 + Emily Davis, Tim Proctor, Gustavo Villagrana, Robert Gu: + repository: git@github.com:BobGu/dinner_dash.git + setup_notes: "" + instructor_evaluation: + notes: "" + rubric: + Feature Completeness: 1 + Views: 3 + Controllers: 3.5 + Models: 4 + TDD: 2.5 + Usability: 1.5 + Allison Larson, Andy Mention, Alan Smith, Will Faurot, Eric Fransen: + repository: git@github.com:ericfransen/dinner_dash.git + setup_notes: "" + instructor_evaluation: + notes: "" + rubric: + Feature Completeness: 2.5 + Views: 3 + Controllers: 3 + Models: 4 + TDD: 4 + Usability: 4 diff --git a/1406/06_the_pivot/the_pivot.markdown b/1406/06_the_pivot/the_pivot.markdown new file mode 100644 index 000000000..9546a5ae3 --- /dev/null +++ b/1406/06_the_pivot/the_pivot.markdown @@ -0,0 +1,58 @@ +Keevahh: + * Registering and posting loans works ok + * Some browsing works + + * Completion: 3 + * Organization: 3 + * Progress: 3 + Technical: + * Lots of pending tests + * 61% coverage + * TDD: 2 + * Code Quality: 3? + * UX: 2 + +EmployMe + * Decent user registration and posting of jobs + * Product + * Completion: 3 + * Organization: 3 + * Progress: 3 + * Technical + * Notes + * `rake spec` suite doesn't run + * some tests fail + * haven't removed irrelevant features/specs + * not really using tests as a suite + * Scores + * TDD: 1 + * Code Quality: 3 + * UX: 2 + +Airlift + * Overall good work leading up to this point + * Some decent work in UX + * Product + * Completion: 3 + * Organization: 3 + * Progress: 3 + * Technical + * Notes + * Love that the tests are all green + * Great scores from Code Climate + * Scores: + * TDD: 4 + * Code Quality: + * UX: 2 + +TravelHome + * Great work on the UX + * Signup aworks well + * Product + * Completion: 3 + * Organization: 3 + * Progress: 3 + * Technicalpu + * TDD: 3 + * Code Quality: 3? Setup code climate + * UX: 4 diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index 41046d056..bef79e561 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -2,17 +2,21 @@ # $ ruby -rpp -ryaml -e 'pp YAML.load File.read("1406/03_sales_engine/sales_engine_submissions.yml") submissions: Jim Sutton & Aaron Paul Wortham: - repository: + repository:https://github.com/a6ftcruton/sales_engine.git setup_notes: "" instructor_evaluation: - notes: "" + notes: "Well tested, but missing some business logic. Tests are consistent and thorough. + Excellent encapsulation and breaking lotic into components -- just not complete with business logic. + Code is easy to read; structured well. + Well-chosen enumerables; one place where could have chained enumerables. Would like to see business logic to get 4. + No problems with line length or confusing methods/variable names." rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Code Sanitation: 0 + Functional Expectations: 2 + Test-Driven Development: 3.5 + Encapsulation / Components: 3 + Fundamental Ruby & Style: 4 + Enumerable & Collections: 3.5 + Code Sanitation: 4 peer_evaluation: notes: "" rubric: @@ -23,17 +27,22 @@ submissions: Enumerable & Collections: 0 Code Sanitation: 0 Cara Dennis & Luke Aiken: - repository: + repository: git@github.com:objectParadigm/sales-engine.git setup_notes: "" instructor_evaluation: - notes: "" + notes: "Some business logic implemented (9 out of 12), but some functionality missing. 7 failing tests when running spec harness. + High-level integration tests are present, but would like to see more isolation and smaller-level integration tests. + Responsibilities are broken down, but some classes rely to heavily on others (repositories loading their own data). + Effort towards clarity and refactoring -- some confusingly-named variables, some long methods. + Good use of varied enumerables; some instances where enumerables were chained where one would have worked. + Code sanitation good -- method names, line length good. " rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Code Sanitation: 0 + Functional Expectations: 2 + Test-Driven Development: 2.5 + Encapsulation / Components: 3 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3.5 + Code Sanitation: 4 peer_evaluation: notes: "" rubric: @@ -43,18 +52,23 @@ submissions: Fundamental Ruby & Style: 0 Enumerable & Collections: 0 Code Sanitation: 0 - Kavita Sachdeva & Sara Simon: + Kavita Sachdeva & Sara Simon: https://github.com/kavitasa/sales_engine repository: setup_notes: "" instructor_evaluation: - notes: "" + notes: "Some business logic attempted, but failing tests in spec harness. + Well-tested with both isolation and integration tests for current functionality. + Separation of concerns is present, but some logic is tightly coupled (merchant repository knowing about parser). + Evidence of refactoring (pulling finder methods into module), would like to have seen the same with parser. + Used appropriate enumerables for features implemented; some instances where enumerables (map + reduce) could be combined. + Some violations with rake sanitation, but most were similar issues in different files." rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Code Sanitation: 0 + Functional Expectations: 2 + Test-Driven Development: 4 + Encapsulation / Components: 3 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Code Sanitation: 3 peer_evaluation: notes: "" rubric: @@ -65,17 +79,17 @@ submissions: Enumerable & Collections: 0 Code Sanitation: 0 Rolando Navarrete & Ian Andersen: - repository: + repository: git@github.com:ianderse/sales_engine.git setup_notes: "" instructor_evaluation: - notes: "" + notes: "Consider using modules to keep code DRY; use of objects to specfic responsibilities was really good; clean short methods most of the time; confident use of Enumerable; functionality was broken out into clear methods" rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Code Sanitation: 0 + Functional Expectations: 4 + Test-Driven Development: 4 + Encapsulation / Components: 3 + Fundamental Ruby & Style: 3.5 + Enumerable & Collections: 4 + Code Sanitation: 4 peer_evaluation: notes: "" rubric: @@ -86,17 +100,17 @@ submissions: Enumerable & Collections: 0 Code Sanitation: 0 Jessica Goulding & Glen Egbert: - repository: + repository: https://github.com/JessicaG/sales_engine setup_notes: "" instructor_evaluation: - notes: "" + notes: "Conditional loaded of CSVs, use of abstracted parser, non-static directory were all good. Consider using modules to keep code DRY, additional objects to handle common tasks, additional methods for granular functionality and better stack traces" rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Code Sanitation: 0 + Functional Expectations: 3 + Test-Driven Development: 4 + Encapsulation / Components: 3 + Fundamental Ruby & Style: 2.5 + Enumerable & Collections: 3 + Code Sanitation: 2 peer_evaluation: notes: "" rubric: diff --git a/1407/04_clone_wars/clone_wars_submissions.yml b/1407/04_clone_wars/clone_wars_submissions.yml new file mode 100644 index 000000000..0c92a38f3 --- /dev/null +++ b/1407/04_clone_wars/clone_wars_submissions.yml @@ -0,0 +1,75 @@ +# NOTE: You can verify that you haven't broken the format with +# $ ruby -rpp -ryaml -e 'pp YAML.load File.read("1406/04_clone_wars/clone_wars_submissions.yml") +submissions: + "Cara Dennis & Jim Sutton & Kavita Sachdeva & Rolando Navarrete": + repository: "git@github.com:objectParadigm/jimmys-urban-bar-and-grill.git" + setup_notes: "" + instructor_evaluation: + notes: "all base expectations fulfilled; added one interactive element. + admin menu able to be edited w/o being logged in as administrator. + some acceptance tests (creating user, creating menu items), but unit tests missing. + used all http verbs; some mixing of web & business logic. + views used layouts and partials to avoid code replication. + many concerns about order of lessons and lack of important concepts in lessons." + rubric: + Functional Expectations: 3 + Test-Driven Development: 2 + Encapsulation / Components: 2.5 + Fundamental Ruby & Style: 2.5 + Sinatra / Web and Business Logic: 3 + View Layer: 3.5 + "Sara Simon & Ian Andersen & Glen Egbert": + repository: "git@github.com:ianderse/clone_wars.git" + setup_notes: "" + instructor_evaluation: + notes: "recreated original site; added banner, contact, reservation, and reviews. + admin able to edit items (name, size, price, image). + saw good testing at feature level; would like to see more things tested in isolation. + good divisions of logic and encapsulation; content store probably could have been broken into a repository and a seracher. + easy to read and follow code. + saw use of layout and partials to avoid code duplication; did not see use of helpers. + " + rubric: + Functional Expectations: 4 + Test-Driven Development: 2 + Encapsulation / Components: 3.5 + Fundamental Ruby & Style: 4 + Sinatra / Web and Business Logic: 3.5 + View Layer: 3.5 + "Jessica Goulding & Luke Aiken & Aaron Paul Wortham": + repository: "https://github.com/JessicaG/slice_works_clone" + setup_notes: "" + instructor_evaluation: + notes: "several routes that do not work (missing template, error pages). + content on pages well-tested; missing tests for user authentication and ability to edit. + started classes for menu and menu item, but not implemented. + would like to see controller not as responsible for executing DB commands and raw sql. + app crashed during execution, but code showed effort toward organization and refactoring. + web and business logic mixed, but used features of Sinatra (Rack::Session, setting variables based on ENV); used helpers to authenticate user + views contain minimal logic; make use of layout and partials; did not see built-in view helpers. + " + rubric: + Functional Expectations: 1 + Test-Driven Development: 2.5 + Encapsulation / Components: 2 + Fundamental Ruby & Style: 1.5 + Sinatra / Web and Business Logic: 2.5 + View Layer: 3.5 + + + + + + + + + + + + + + + + + +