From cfb0f9f04be4372232de359079c0ffd33a365ed3 Mon Sep 17 00:00:00 2001 From: Ian Andersen Date: Thu, 28 Aug 2014 08:26:30 -0600 Subject: [PATCH 01/25] Update sales_engine_submissions.yml --- 1407/03_sales_engine/sales_engine_submissions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index 41046d056..a62e46b3e 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -65,7 +65,7 @@ submissions: Enumerable & Collections: 0 Code Sanitation: 0 Rolando Navarrete & Ian Andersen: - repository: + repository: git@github.com:ianderse/sales_engine.git setup_notes: "" instructor_evaluation: notes: "" From 31ddaf9255809a1c92042a270b9a184b50ae9337 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Thu, 28 Aug 2014 08:28:25 -0600 Subject: [PATCH 02/25] Added Dinner Dash file --- .../dinner_dash_submissions.yml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 1406/05_dinner_dash/dinner_dash_submissions.yml diff --git a/1406/05_dinner_dash/dinner_dash_submissions.yml b/1406/05_dinner_dash/dinner_dash_submissions.yml new file mode 100644 index 000000000..f5b12a879 --- /dev/null +++ b/1406/05_dinner_dash/dinner_dash_submissions.yml @@ -0,0 +1,51 @@ +# NOTE: You can verify that you haven't broken the format with +# $ ruby -rpp -ryaml -e 'pp YAML.load File.read("1406/04_clone_wars/clone_wars_submissions.yml") +submissions: + Andrew Watkins, Jonmichael Chambers, Marc Garreau, Chad Brading: + repository: + setup_notes: "" + instructor_evaluation: + notes: "" + rubric: + Functional Expectations: 0 + Test-Driven Development: 0 + Encapsulation / Components: 0 + Fundamental Ruby & Style: 0 + Sinatra / Web and Business Logic: 0 + View Layer: 0 + Horacio Chavez, Corey Davis, Tan Doan, Hilary Denton: + repository: + setup_notes: "" + instructor_evaluation: + notes: "" + rubric: + Functional Expectations: 0 + Test-Driven Development: 0 + Encapsulation / Components: 0 + Fundamental Ruby & Style: 0 + Sinatra / Web and Business Logic: 0 + View Layer: 0 + Emily Davis, Tim Proctor, Gustavo Villagrana, Robert Gu: + repository: + setup_notes: "" + instructor_evaluation: + notes: "" + rubric: + Functional Expectations: 0 + Test-Driven Development: 0 + Encapsulation / Components: 0 + Fundamental Ruby & Style: 0 + Sinatra / Web and Business Logic: 0 + View Layer: 0 + Allison Larson, Andy Mention, Alan Smith, Will Faurot, Eric Fransen: + repository: + setup_notes: "" + instructor_evaluation: + notes: "" + rubric: + Functional Expectations: 0 + Test-Driven Development: 0 + Encapsulation / Components: 0 + Fundamental Ruby & Style: 0 + Sinatra / Web and Business Logic: 0 + View Layer: 0 From 0550917647cc716994ff168a6b6c47428f6560fb Mon Sep 17 00:00:00 2001 From: Jessica Goulding Date: Thu, 28 Aug 2014 08:31:01 -0600 Subject: [PATCH 03/25] Update sales_engine_submissions.yml --- 1407/03_sales_engine/sales_engine_submissions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index a62e46b3e..d2b791a30 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -86,7 +86,7 @@ submissions: Enumerable & Collections: 0 Code Sanitation: 0 Jessica Goulding & Glen Egbert: - repository: + repository: https://github.com/JessicaG/sales_engine setup_notes: "" instructor_evaluation: notes: "" From 539456f03afd427e49cecc316949cc9ee2b32bc3 Mon Sep 17 00:00:00 2001 From: objectParadigm Date: Thu, 28 Aug 2014 08:37:07 -0600 Subject: [PATCH 04/25] Update sales_engine_submissions.yml --- 1407/03_sales_engine/sales_engine_submissions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index d2b791a30..660d0444f 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -23,7 +23,7 @@ submissions: Enumerable & Collections: 0 Code Sanitation: 0 Cara Dennis & Luke Aiken: - repository: + repository: git@github.com:objectParadigm/sales-engine.git setup_notes: "" instructor_evaluation: notes: "" From 8c334b8ba99fc1aa173f0d03dd7145f939cee015 Mon Sep 17 00:00:00 2001 From: a6ftcruton Date: Thu, 28 Aug 2014 08:38:46 -0600 Subject: [PATCH 05/25] Update sales_engine_submissions.yml --- 1407/03_sales_engine/sales_engine_submissions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index d2b791a30..5be96a6dc 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -2,7 +2,7 @@ # $ ruby -rpp -ryaml -e 'pp YAML.load File.read("1406/03_sales_engine/sales_engine_submissions.yml") submissions: Jim Sutton & Aaron Paul Wortham: - repository: + repository:https://github.com/a6ftcruton/sales_engine.git setup_notes: "" instructor_evaluation: notes: "" From cc0f18c795316a0743c96ff361c4c2127cedc29d Mon Sep 17 00:00:00 2001 From: kavitasa Date: Thu, 28 Aug 2014 09:02:26 -0600 Subject: [PATCH 06/25] Update sales_engine_submissions.yml --- 1407/03_sales_engine/sales_engine_submissions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index 3928dc4e4..642e93f11 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -43,7 +43,7 @@ submissions: Fundamental Ruby & Style: 0 Enumerable & Collections: 0 Code Sanitation: 0 - Kavita Sachdeva & Sara Simon: + Kavita Sachdeva & Sara Simon: https://github.com/kavitasa/sales_engine repository: setup_notes: "" instructor_evaluation: From 939dc19ffc6b9f4040cf088024d3154d231006f2 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Thu, 28 Aug 2014 09:11:34 -0600 Subject: [PATCH 07/25] Adding corrected rubric --- .../dinner_dash_submissions.yml | 54 +++++++++---------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/1406/05_dinner_dash/dinner_dash_submissions.yml b/1406/05_dinner_dash/dinner_dash_submissions.yml index f5b12a879..41dc8220d 100644 --- a/1406/05_dinner_dash/dinner_dash_submissions.yml +++ b/1406/05_dinner_dash/dinner_dash_submissions.yml @@ -7,45 +7,45 @@ submissions: instructor_evaluation: notes: "" rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Sinatra / Web and Business Logic: 0 - View Layer: 0 + Feature Completeness: 0 + Views: 0 + Controllers: 0 + Models: 0 + TDD: 0 + Usability: 0 Horacio Chavez, Corey Davis, Tan Doan, Hilary Denton: repository: setup_notes: "" instructor_evaluation: notes: "" - rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Sinatra / Web and Business Logic: 0 - View Layer: 0 + rubric: + Feature Completeness: 0 + Views: 0 + Controllers: 0 + Models: 0 + TDD: 0 + Usability: 0 Emily Davis, Tim Proctor, Gustavo Villagrana, Robert Gu: repository: setup_notes: "" instructor_evaluation: notes: "" - rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Sinatra / Web and Business Logic: 0 - View Layer: 0 + rubric: + Feature Completeness: 0 + Views: 0 + Controllers: 0 + Models: 0 + TDD: 0 + Usability: 0 Allison Larson, Andy Mention, Alan Smith, Will Faurot, Eric Fransen: repository: setup_notes: "" instructor_evaluation: notes: "" - rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Sinatra / Web and Business Logic: 0 - View Layer: 0 + rubric: + Feature Completeness: 0 + Views: 0 + Controllers: 0 + Models: 0 + TDD: 0 + Usability: 0 From 676eddb5e930e6462c323cfd9b945da2586c61bb Mon Sep 17 00:00:00 2001 From: Jorge Tellez Date: Thu, 28 Aug 2014 09:48:19 -0600 Subject: [PATCH 08/25] Dangerously Delicious Evaluation --- 1406/05_dinner_dash/dinner_dash_submissions.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/1406/05_dinner_dash/dinner_dash_submissions.yml b/1406/05_dinner_dash/dinner_dash_submissions.yml index 41dc8220d..381dc93e0 100644 --- a/1406/05_dinner_dash/dinner_dash_submissions.yml +++ b/1406/05_dinner_dash/dinner_dash_submissions.yml @@ -31,12 +31,12 @@ submissions: instructor_evaluation: notes: "" rubric: - Feature Completeness: 0 - Views: 0 - Controllers: 0 - Models: 0 - TDD: 0 - Usability: 0 + Feature Completeness: 1 + Views: 3 + Controllers: 3.5 + Models: 4 + TDD: 2.5 + Usability: 1.5 Allison Larson, Andy Mention, Alan Smith, Will Faurot, Eric Fransen: repository: setup_notes: "" From c77a209d3bcabe8537d8a029dd8f0112edfd5ed9 Mon Sep 17 00:00:00 2001 From: Jorge Tellez Date: Thu, 28 Aug 2014 09:50:48 -0600 Subject: [PATCH 09/25] Update dinner_dash_submissions.yml --- 1406/05_dinner_dash/dinner_dash_submissions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1406/05_dinner_dash/dinner_dash_submissions.yml b/1406/05_dinner_dash/dinner_dash_submissions.yml index 381dc93e0..414ef411d 100644 --- a/1406/05_dinner_dash/dinner_dash_submissions.yml +++ b/1406/05_dinner_dash/dinner_dash_submissions.yml @@ -26,7 +26,7 @@ submissions: TDD: 0 Usability: 0 Emily Davis, Tim Proctor, Gustavo Villagrana, Robert Gu: - repository: + repository: git@github.com:BobGu/dinner_dash.git setup_notes: "" instructor_evaluation: notes: "" From b9fe034f53af424afb04f783a9412753da6b2b78 Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 28 Aug 2014 09:56:57 -0600 Subject: [PATCH 10/25] Update sales_engine_submissions.yml --- .../sales_engine_submissions.yml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index 3928dc4e4..ec36097f2 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -5,14 +5,18 @@ submissions: repository:https://github.com/a6ftcruton/sales_engine.git setup_notes: "" instructor_evaluation: - notes: "" + notes: "Well tested, but missing some business logic. Tests are consistent and thorough. + Excellent encapsulation and breaking lotic into components -- just not complete with business logic. + Code is easy to read; structured well. + Well-chosen enumerables; one place where could have chained enumerables. Would like to see business logic to get 4. + No problems with line length or confusing methods/variable names." rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Code Sanitation: 0 + Functional Expectations: 2 + Test-Driven Development: 3.5 + Encapsulation / Components: 3 + Fundamental Ruby & Style: 4 + Enumerable & Collections: 3.5 + Code Sanitation: 4 peer_evaluation: notes: "" rubric: From 3da0a1353ad73351a5c86e0f44490499e18140b7 Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 28 Aug 2014 10:34:15 -0600 Subject: [PATCH 11/25] Update sales_engine_submissions.yml --- .../sales_engine_submissions.yml | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index ec36097f2..a2b73499c 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -30,14 +30,19 @@ submissions: repository: git@github.com:objectParadigm/sales-engine.git setup_notes: "" instructor_evaluation: - notes: "" + notes: "Some business logic implemented (9 out of 12), but some functionality missing. 7 failing tests when running spec harness. + High-level integration tests are present, but would like to see more isolation and smaller-level integration tests. + Responsibilities are broken down, but some classes rely to heavily on others (repositories loading their own data). + Effort towards clarity and refactoring -- some confusingly-named variables, some long methods. + Good use of varied enumerables; some instances where enumerables were chained where one would have worked. + Code sanitation good -- method names, line length good. " rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Code Sanitation: 0 + Functional Expectations: 2 + Test-Driven Development: 2.5 + Encapsulation / Components: 3 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3.5 + Code Sanitation: 4 peer_evaluation: notes: "" rubric: From 5957c51d92f9e25aad9b78d01123150ba2a984a4 Mon Sep 17 00:00:00 2001 From: Jorge Tellez Date: Thu, 28 Aug 2014 11:08:05 -0600 Subject: [PATCH 12/25] Endangered Eats Evaluation --- 1406/05_dinner_dash/dinner_dash_submissions.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/1406/05_dinner_dash/dinner_dash_submissions.yml b/1406/05_dinner_dash/dinner_dash_submissions.yml index 414ef411d..23f80088d 100644 --- a/1406/05_dinner_dash/dinner_dash_submissions.yml +++ b/1406/05_dinner_dash/dinner_dash_submissions.yml @@ -38,14 +38,14 @@ submissions: TDD: 2.5 Usability: 1.5 Allison Larson, Andy Mention, Alan Smith, Will Faurot, Eric Fransen: - repository: + repository: git@github.com:ericfransen/dinner_dash.git setup_notes: "" instructor_evaluation: notes: "" rubric: - Feature Completeness: 0 - Views: 0 - Controllers: 0 - Models: 0 - TDD: 0 - Usability: 0 + Feature Completeness: 2.5 + Views: 3 + Controllers: 3 + Models: 4 + TDD: 4 + Usability: 4 From c967136d86b716f998eaa6e3fdbf4f803a5806c5 Mon Sep 17 00:00:00 2001 From: Steve Kinney Date: Thu, 28 Aug 2014 11:23:25 -0600 Subject: [PATCH 13/25] Add scores for Ian, Ronaldo, Jessica, and Glen --- .../sales_engine_submissions.yml | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index 7fbbfd680..147e7c034 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -56,14 +56,14 @@ submissions: repository: setup_notes: "" instructor_evaluation: - notes: "" + notes: "Conditional loaded of CSVs, use of abstracted parser, non-static directory were all good. Consider using modules to keep code DRY, additional objects to handle common tasks, additional methods for granular functionality and better stack traces" rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Code Sanitation: 0 + Functional Expectations: 3 + Test-Driven Development: 4 + Encapsulation / Components: 3 + Fundamental Ruby & Style: 2.5 + Enumerable & Collections: 3 + Code Sanitation: 2 peer_evaluation: notes: "" rubric: @@ -77,14 +77,14 @@ submissions: repository: git@github.com:ianderse/sales_engine.git setup_notes: "" instructor_evaluation: - notes: "" + notes: "Consider using modules to keep code DRY; use of objects to specfic responsibilities was really good; clean short methods most of the time; confident use of Enumerable; functionality was broken out into clear methods" rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Code Sanitation: 0 + Functional Expectations: 4 + Test-Driven Development: 4 + Encapsulation / Components: 3 + Fundamental Ruby & Style: 3.5 + Enumerable & Collections: 4 + Code Sanitation: 4 peer_evaluation: notes: "" rubric: From d097dd746c7ea46a3f0d78fd74da725c0bdde5d5 Mon Sep 17 00:00:00 2001 From: Steve Kinney Date: Thu, 28 Aug 2014 11:27:15 -0600 Subject: [PATCH 14/25] One more shot at Glen and Jessica's scores --- .../sales_engine_submissions.yml | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index 147e7c034..bac7d768a 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -5,8 +5,8 @@ submissions: repository:https://github.com/a6ftcruton/sales_engine.git setup_notes: "" instructor_evaluation: - notes: "Well tested, but missing some business logic. Tests are consistent and thorough. - Excellent encapsulation and breaking lotic into components -- just not complete with business logic. + notes: "Well tested, but missing some business logic. Tests are consistent and thorough. + Excellent encapsulation and breaking lotic into components -- just not complete with business logic. Code is easy to read; structured well. Well-chosen enumerables; one place where could have chained enumerables. Would like to see business logic to get 4. No problems with line length or confusing methods/variable names." @@ -31,7 +31,7 @@ submissions: setup_notes: "" instructor_evaluation: notes: "Some business logic implemented (9 out of 12), but some functionality missing. 7 failing tests when running spec harness. - High-level integration tests are present, but would like to see more isolation and smaller-level integration tests. + High-level integration tests are present, but would like to see more isolation and smaller-level integration tests. Responsibilities are broken down, but some classes rely to heavily on others (repositories loading their own data). Effort towards clarity and refactoring -- some confusingly-named variables, some long methods. Good use of varied enumerables; some instances where enumerables were chained where one would have worked. @@ -98,14 +98,14 @@ submissions: repository: https://github.com/JessicaG/sales_engine setup_notes: "" instructor_evaluation: - notes: "" + notes: "Conditional loaded of CSVs, use of abstracted parser, non-static directory were all good. Consider using modules to keep code DRY, additional objects to handle common tasks, additional methods for granular functionality and better stack traces" rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Code Sanitation: 0 + Functional Expectations: 3 + Test-Driven Development: 4 + Encapsulation / Components: 3 + Fundamental Ruby & Style: 2.5 + Enumerable & Collections: 3 + Code Sanitation: 2 peer_evaluation: notes: "" rubric: From 8c992bb914080ae985b2c3b1d60fd2a6eb4ec511 Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 28 Aug 2014 11:37:47 -0600 Subject: [PATCH 15/25] Update sales_engine_submissions.yml --- 1407/03_sales_engine/sales_engine_submissions.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/1407/03_sales_engine/sales_engine_submissions.yml b/1407/03_sales_engine/sales_engine_submissions.yml index bac7d768a..bef79e561 100644 --- a/1407/03_sales_engine/sales_engine_submissions.yml +++ b/1407/03_sales_engine/sales_engine_submissions.yml @@ -52,18 +52,23 @@ submissions: Fundamental Ruby & Style: 0 Enumerable & Collections: 0 Code Sanitation: 0 - Kavita Sachdeva & Sara Simon: https://github.com/kavitasa/sales_engine + Kavita Sachdeva & Sara Simon: https://github.com/kavitasa/sales_engine repository: setup_notes: "" instructor_evaluation: - notes: "Conditional loaded of CSVs, use of abstracted parser, non-static directory were all good. Consider using modules to keep code DRY, additional objects to handle common tasks, additional methods for granular functionality and better stack traces" + notes: "Some business logic attempted, but failing tests in spec harness. + Well-tested with both isolation and integration tests for current functionality. + Separation of concerns is present, but some logic is tightly coupled (merchant repository knowing about parser). + Evidence of refactoring (pulling finder methods into module), would like to have seen the same with parser. + Used appropriate enumerables for features implemented; some instances where enumerables (map + reduce) could be combined. + Some violations with rake sanitation, but most were similar issues in different files." rubric: - Functional Expectations: 3 + Functional Expectations: 2 Test-Driven Development: 4 Encapsulation / Components: 3 - Fundamental Ruby & Style: 2.5 + Fundamental Ruby & Style: 3 Enumerable & Collections: 3 - Code Sanitation: 2 + Code Sanitation: 3 peer_evaluation: notes: "" rubric: From 2784098784b7347cd5856d11b15338cf05a348a5 Mon Sep 17 00:00:00 2001 From: Josh Cheek Date: Sat, 30 Aug 2014 13:02:39 -0600 Subject: [PATCH 16/25] Add 1406 dinner dash evaluations --- .../dinner_dash_submissions.yml | 63 ++++++++++++++----- 1 file changed, 49 insertions(+), 14 deletions(-) diff --git a/1406/05_dinner_dash/dinner_dash_submissions.yml b/1406/05_dinner_dash/dinner_dash_submissions.yml index 23f80088d..577599281 100644 --- a/1406/05_dinner_dash/dinner_dash_submissions.yml +++ b/1406/05_dinner_dash/dinner_dash_submissions.yml @@ -5,26 +5,61 @@ submissions: repository: setup_notes: "" instructor_evaluation: - notes: "" + notes: | + can't log out ;p~~~~~~ + users and accounts are the same thing + nice use of presenters + Good tests in general, tiny bit not covered, but not for a particularly good reason + Can't log out, yo, sharing my cart with mah homies + no link to category + orders "all" counts current order rubric: - Feature Completeness: 0 - Views: 0 - Controllers: 0 - Models: 0 - TDD: 0 - Usability: 0 + Feature Completeness: 3 + Views: 4 + Controllers: 3 + Models: 4 + TDD: 4- + Usability: 3 Horacio Chavez, Corey Davis, Tan Doan, Hilary Denton: repository: setup_notes: "" instructor_evaluation: - notes: "" + notes: | + Feature Completeness + No link to my profile/orders + can see other people's orders + cart is gone forever when I logout :( + Can't edit user info + admin orders missing total + some links to transition that aren't actually available + no Heroku :P + Views + use state machine instead of logic in admin orders view + the logic that was there was wrong + correctly indent the code + find balance between the pristine pages (menu, front page) and the rest + Controllers + lots of dead code + unnecessary json stuff + session helper is better in application controller + need to push knowledge of things like `role == 'admin'` down + Models + TDD + high coverage, if you delete dead code :) + things tested at feature level that would be better at a more focused level + (e.g. I don't want to deal with the internet just to test how long a password can be) + Usability + most of the reasons are documented under features + Unused routes + most pages need aesthetic work + the map doesn't show rubric: - Feature Completeness: 0 - Views: 0 - Controllers: 0 - Models: 0 - TDD: 0 - Usability: 0 + Feature Completeness: 1.5 + Views: 3 + Controllers: 3 + Models: 3.5 + TDD: 3 + Usability: 2 Emily Davis, Tim Proctor, Gustavo Villagrana, Robert Gu: repository: git@github.com:BobGu/dinner_dash.git setup_notes: "" From cb813a8a174e36acd79de8f4481bdc03377ddda0 Mon Sep 17 00:00:00 2001 From: Josh Cheek Date: Sat, 30 Aug 2014 13:08:49 -0600 Subject: [PATCH 17/25] Add that I was the evaluator in the notes on mine --- 1406/05_dinner_dash/dinner_dash_submissions.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/1406/05_dinner_dash/dinner_dash_submissions.yml b/1406/05_dinner_dash/dinner_dash_submissions.yml index 577599281..284fffef4 100644 --- a/1406/05_dinner_dash/dinner_dash_submissions.yml +++ b/1406/05_dinner_dash/dinner_dash_submissions.yml @@ -6,6 +6,7 @@ submissions: setup_notes: "" instructor_evaluation: notes: | + Evaluated by Josh can't log out ;p~~~~~~ users and accounts are the same thing nice use of presenters @@ -25,6 +26,7 @@ submissions: setup_notes: "" instructor_evaluation: notes: | + Evaluated by Josh Feature Completeness No link to my profile/orders can see other people's orders From 96457ee7261553f1338693c3e5d5d2b467f62210 Mon Sep 17 00:00:00 2001 From: Josh Cheek Date: Sat, 30 Aug 2014 13:09:07 -0600 Subject: [PATCH 18/25] Based on previous submissions, "rubric" should be under "instructor_evaluation" --- .../dinner_dash_submissions.yml | 42 +++++++++---------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/1406/05_dinner_dash/dinner_dash_submissions.yml b/1406/05_dinner_dash/dinner_dash_submissions.yml index 284fffef4..bc6ca7edc 100644 --- a/1406/05_dinner_dash/dinner_dash_submissions.yml +++ b/1406/05_dinner_dash/dinner_dash_submissions.yml @@ -55,34 +55,34 @@ submissions: Unused routes most pages need aesthetic work the map doesn't show - rubric: - Feature Completeness: 1.5 - Views: 3 - Controllers: 3 - Models: 3.5 - TDD: 3 - Usability: 2 + rubric: + Feature Completeness: 1.5 + Views: 3 + Controllers: 3 + Models: 3.5 + TDD: 3 + Usability: 2 Emily Davis, Tim Proctor, Gustavo Villagrana, Robert Gu: repository: git@github.com:BobGu/dinner_dash.git setup_notes: "" instructor_evaluation: notes: "" - rubric: - Feature Completeness: 1 - Views: 3 - Controllers: 3.5 - Models: 4 - TDD: 2.5 - Usability: 1.5 + rubric: + Feature Completeness: 1 + Views: 3 + Controllers: 3.5 + Models: 4 + TDD: 2.5 + Usability: 1.5 Allison Larson, Andy Mention, Alan Smith, Will Faurot, Eric Fransen: repository: git@github.com:ericfransen/dinner_dash.git setup_notes: "" instructor_evaluation: notes: "" - rubric: - Feature Completeness: 2.5 - Views: 3 - Controllers: 3 - Models: 4 - TDD: 4 - Usability: 4 + rubric: + Feature Completeness: 2.5 + Views: 3 + Controllers: 3 + Models: 4 + TDD: 4 + Usability: 4 From 7e6021592a4bc1b27812822efa52158d00b9b2af Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Wed, 17 Sep 2014 20:47:33 -0600 Subject: [PATCH 19/25] Template submissions for clone wars --- 1407/04_clone_wars/clone_wars_submissions.yml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 1407/04_clone_wars/clone_wars_submissions.yml diff --git a/1407/04_clone_wars/clone_wars_submissions.yml b/1407/04_clone_wars/clone_wars_submissions.yml new file mode 100644 index 000000000..80e742348 --- /dev/null +++ b/1407/04_clone_wars/clone_wars_submissions.yml @@ -0,0 +1,39 @@ +# NOTE: You can verify that you haven't broken the format with +# $ ruby -rpp -ryaml -e 'pp YAML.load File.read("1406/04_clone_wars/clone_wars_submissions.yml") +submissions: + "Cara Dennis & Jim Sutton & Kavita Sachdeva & Rolando Navarrete": + repository: "" + setup_notes: "" + instructor_evaluation: + notes: "" + rubric: + Functional Expectations: 0 + Test-Driven Development: 0 + Encapsulation / Components: 0 + Fundamental Ruby & Style: 0 + Sinatra / Web and Business Logic: 0 + View Layer: 0 + "Sara Simon & Ian Andersen & Glen Egbert": + repository: "" + setup_notes: "" + instructor_evaluation: + notes: "" + rubric: + Functional Expectations: 0 + Test-Driven Development: 0 + Encapsulation / Components: 0 + Fundamental Ruby & Style: 0 + Sinatra / Web and Business Logic: 0 + View Layer: 0 + "Jessica Goulding & Luke Aiken & Aaron Paul Wortham": + repository: "" + setup_notes: "" + instructor_evaluation: + notes: "" + rubric: + Functional Expectations: 0 + Test-Driven Development: 0 + Encapsulation / Components: 0 + Fundamental Ruby & Style: 0 + Sinatra / Web and Business Logic: 0 + View Layer: 0 From a127dbad41d8472883654b69472f74f2c4096283 Mon Sep 17 00:00:00 2001 From: Jeff Casimir Date: Wed, 17 Sep 2014 20:47:47 -0600 Subject: [PATCH 20/25] First Pivot check-in scores --- 1406/06_the_pivot/the_pivot.markdown | 58 ++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 1406/06_the_pivot/the_pivot.markdown diff --git a/1406/06_the_pivot/the_pivot.markdown b/1406/06_the_pivot/the_pivot.markdown new file mode 100644 index 000000000..9546a5ae3 --- /dev/null +++ b/1406/06_the_pivot/the_pivot.markdown @@ -0,0 +1,58 @@ +Keevahh: + * Registering and posting loans works ok + * Some browsing works + + * Completion: 3 + * Organization: 3 + * Progress: 3 + Technical: + * Lots of pending tests + * 61% coverage + * TDD: 2 + * Code Quality: 3? + * UX: 2 + +EmployMe + * Decent user registration and posting of jobs + * Product + * Completion: 3 + * Organization: 3 + * Progress: 3 + * Technical + * Notes + * `rake spec` suite doesn't run + * some tests fail + * haven't removed irrelevant features/specs + * not really using tests as a suite + * Scores + * TDD: 1 + * Code Quality: 3 + * UX: 2 + +Airlift + * Overall good work leading up to this point + * Some decent work in UX + * Product + * Completion: 3 + * Organization: 3 + * Progress: 3 + * Technical + * Notes + * Love that the tests are all green + * Great scores from Code Climate + * Scores: + * TDD: 4 + * Code Quality: + * UX: 2 + +TravelHome + * Great work on the UX + * Signup aworks well + * Product + * Completion: 3 + * Organization: 3 + * Progress: 3 + * Technicalpu + * TDD: 3 + * Code Quality: 3? Setup code climate + * UX: 4 From 474f9d02e6ba99f127cde5b4d74a0cff24533040 Mon Sep 17 00:00:00 2001 From: Jessica Goulding Date: Wed, 17 Sep 2014 20:50:18 -0600 Subject: [PATCH 21/25] Update clone_wars_submissions.yml Slice Works Group Repo, Jessica, Luke & Aaron --- 1407/04_clone_wars/clone_wars_submissions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1407/04_clone_wars/clone_wars_submissions.yml b/1407/04_clone_wars/clone_wars_submissions.yml index 80e742348..da0f70a68 100644 --- a/1407/04_clone_wars/clone_wars_submissions.yml +++ b/1407/04_clone_wars/clone_wars_submissions.yml @@ -26,7 +26,7 @@ submissions: Sinatra / Web and Business Logic: 0 View Layer: 0 "Jessica Goulding & Luke Aiken & Aaron Paul Wortham": - repository: "" + repository: "https://github.com/JessicaG/slice_works_clone" setup_notes: "" instructor_evaluation: notes: "" From 4c190bb3639a104e6b38d9e924ec241d42705b87 Mon Sep 17 00:00:00 2001 From: Ian Andersen Date: Thu, 18 Sep 2014 08:53:00 -0600 Subject: [PATCH 22/25] Update clone_wars_submissions.yml --- 1407/04_clone_wars/clone_wars_submissions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1407/04_clone_wars/clone_wars_submissions.yml b/1407/04_clone_wars/clone_wars_submissions.yml index 80e742348..5d0a6d2fc 100644 --- a/1407/04_clone_wars/clone_wars_submissions.yml +++ b/1407/04_clone_wars/clone_wars_submissions.yml @@ -14,7 +14,7 @@ submissions: Sinatra / Web and Business Logic: 0 View Layer: 0 "Sara Simon & Ian Andersen & Glen Egbert": - repository: "" + repository: "git@github.com:ianderse/clone_wars.git" setup_notes: "" instructor_evaluation: notes: "" From ed8936a0b749f1ab56ce5ab4bf6399d94319666f Mon Sep 17 00:00:00 2001 From: objectParadigm Date: Thu, 18 Sep 2014 09:10:33 -0600 Subject: [PATCH 23/25] Update clone_wars_submissions.yml --- 1407/04_clone_wars/clone_wars_submissions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1407/04_clone_wars/clone_wars_submissions.yml b/1407/04_clone_wars/clone_wars_submissions.yml index 4dff75e50..1a3cb200b 100644 --- a/1407/04_clone_wars/clone_wars_submissions.yml +++ b/1407/04_clone_wars/clone_wars_submissions.yml @@ -2,7 +2,7 @@ # $ ruby -rpp -ryaml -e 'pp YAML.load File.read("1406/04_clone_wars/clone_wars_submissions.yml") submissions: "Cara Dennis & Jim Sutton & Kavita Sachdeva & Rolando Navarrete": - repository: "" + repository: "git@github.com:objectParadigm/jimmys-urban-bar-and-grill.git" setup_notes: "" instructor_evaluation: notes: "" From c760af3eec83e84c31153224c28802a10bc52ace Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 18 Sep 2014 11:02:05 -0600 Subject: [PATCH 24/25] Update clone_wars_submissions.yml --- 1407/04_clone_wars/clone_wars_submissions.yml | 39 ++++++++++++------- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/1407/04_clone_wars/clone_wars_submissions.yml b/1407/04_clone_wars/clone_wars_submissions.yml index 1a3cb200b..b511e4ef2 100644 --- a/1407/04_clone_wars/clone_wars_submissions.yml +++ b/1407/04_clone_wars/clone_wars_submissions.yml @@ -5,26 +5,37 @@ submissions: repository: "git@github.com:objectParadigm/jimmys-urban-bar-and-grill.git" setup_notes: "" instructor_evaluation: - notes: "" + notes: "all base expectations fulfilled; added one interactive element. + admin menu able to be edited w/o being logged in as administrator. + some acceptance tests (creating user, creating menu items), but unit tests missing. + used all http verbs; some mixing of web & business logic. + views used layouts and partials to avoid code replication. + many concerns about order of lessons and lack of important concepts in lessons." rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Sinatra / Web and Business Logic: 0 - View Layer: 0 + Functional Expectations: 3 + Test-Driven Development: 2 + Encapsulation / Components: 2.5 + Fundamental Ruby & Style: 2.5 + Sinatra / Web and Business Logic: 3 + View Layer: 3.5 "Sara Simon & Ian Andersen & Glen Egbert": repository: "git@github.com:ianderse/clone_wars.git" setup_notes: "" instructor_evaluation: - notes: "" + notes: "recreated original site; added banner, contact, reservation, and reviews. + admin able to edit items (name, size, price, image). + saw good testing at feature level; would like to see more things tested in isolation. + good divisions of logic and encapsulation; content store probably could have been broken into a repository and a seracher. + easy to read and follow code. + saw use of layout and partials to avoid code duplication; did not see use of helpers. + " rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Sinatra / Web and Business Logic: 0 - View Layer: 0 + Functional Expectations: 4 + Test-Driven Development: 2 + Encapsulation / Components: 3.5 + Fundamental Ruby & Style: 4 + Sinatra / Web and Business Logic: 3.5 + View Layer: 3.5 "Jessica Goulding & Luke Aiken & Aaron Paul Wortham": repository: "https://github.com/JessicaG/slice_works_clone" setup_notes: "" From 41a5a4efd9c04113e992a09b71aee53f9af533f6 Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 18 Sep 2014 11:56:46 -0600 Subject: [PATCH 25/25] Update clone_wars_submissions.yml --- 1407/04_clone_wars/clone_wars_submissions.yml | 39 +++++++++++++++---- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/1407/04_clone_wars/clone_wars_submissions.yml b/1407/04_clone_wars/clone_wars_submissions.yml index b511e4ef2..0c92a38f3 100644 --- a/1407/04_clone_wars/clone_wars_submissions.yml +++ b/1407/04_clone_wars/clone_wars_submissions.yml @@ -40,11 +40,36 @@ submissions: repository: "https://github.com/JessicaG/slice_works_clone" setup_notes: "" instructor_evaluation: - notes: "" + notes: "several routes that do not work (missing template, error pages). + content on pages well-tested; missing tests for user authentication and ability to edit. + started classes for menu and menu item, but not implemented. + would like to see controller not as responsible for executing DB commands and raw sql. + app crashed during execution, but code showed effort toward organization and refactoring. + web and business logic mixed, but used features of Sinatra (Rack::Session, setting variables based on ENV); used helpers to authenticate user + views contain minimal logic; make use of layout and partials; did not see built-in view helpers. + " rubric: - Functional Expectations: 0 - Test-Driven Development: 0 - Encapsulation / Components: 0 - Fundamental Ruby & Style: 0 - Sinatra / Web and Business Logic: 0 - View Layer: 0 + Functional Expectations: 1 + Test-Driven Development: 2.5 + Encapsulation / Components: 2 + Fundamental Ruby & Style: 1.5 + Sinatra / Web and Business Logic: 2.5 + View Layer: 3.5 + + + + + + + + + + + + + + + + + +