diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index 5ec2d7fb6..7ccb5335b 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -1,13 +1,17 @@ submissions: Alex Jensen: repository: https://github.com/danajensen/mastermind - notes: "" - evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + notes: "Shows strong effort toward organization. Some closely-coupled objects. + Good use of best-choice enumerables (collect, any? zip). + Well-tested in isolation and integration. + Integrated difficulty level in REPL. Clear to use. + Saw intent to break apart logical components, but some objects tied together that will make future iterations or changes difficult to implement." + evaluation: + Fundamental Ruby & Style: 3.5 + Enumerable & Collections: 4 + Test-Driven Development: 4 + REPL Interface: 3.5 + Breaking Logic into Components: 3 Herbert Joseph: repository: https://github.com/Copywright/mastermind notes: "Don't kill me..." @@ -100,7 +104,9 @@ submissions: Breaking Logic into Components: 0 Chase van Hekken: repository: https://github.com/ChasevanHekken/mastermind-game.git - notes: "" + notes: "Definitely shows a growing grasp of OO concepts and idiomatic Ruby. + had some long and methods that did multiple things. + Also had a few classes that had to reach a bit too deeply to keep the game logic together." evaluation: Fundamental Ruby & Style: 2.5 Enumerable & Collections: 2.5 @@ -108,47 +114,54 @@ submissions: REPL Interface: 3 Breaking Logic into Components: 2.5 Victoria Harrod: - repository: - notes: "" + repository: https://github.com/VikiAnn/mastermind + notes: "Had some components that were well thought out. + Some of the tests were superficial. + Developing a good grasp of OO concepts." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 2.5 + Enumerable & Collections: 3 + Test-Driven Development: 2.5 + REPL Interface: 3 + Breaking Logic into Components: 2.5 Kalah Cheek: repository: https://github.com/kcheek/mastermind.git - notes: "" + notes: "Was able to defend design decisions. + Limited test coverage." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 2.5 + Enumerable & Collections: 3 + Test-Driven Development: 2 + REPL Interface: 3 + Breaking Logic into Components: 3 Travis Yoder: - repository: - notes: "" - evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + repository: "https://github.com/trayo/mastermind.git" + notes: "Some incomplete tests. + Several good attempts at trying to split up logical components into + individual classes." + evaluation: + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 2 + REPL Interface: 3 + Breaking Logic into Components: 3 Danny Glunz: repository: - notes: "" - evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + notes: "Completed both Mastermind and Battleship. + Lacking sufficient test coverage." + evaluation: + Fundamental Ruby & Style: 4 + Enumerable & Collections: 4 + Test-Driven Development: 2 + REPL Interface: 4 + Breaking Logic into Components: 3.5 Chandra Carney: repository: - notes: "" + notes: "Lacking test coverage. + Good use of enumerable and Ruby style." evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + Fundamental Ruby & Style: 3 + Enumerable & Collections: 3 + Test-Driven Development: 2 + REPL Interface: 3 + Breaking Logic into Components: 2.5