From e3c2807a9a00aed04f4f4fc182ee39da2447cc46 Mon Sep 17 00:00:00 2001 From: VikiAnn Date: Thu, 25 Sep 2014 12:15:42 -0600 Subject: [PATCH 1/2] added link to my repo --- 1409/01_mastermind/mastermind_submissions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index 7878ce883..ee762027e 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -108,7 +108,7 @@ submissions: REPL Interface: 0 Breaking Logic into Components: 0 Victoria Harrod: - repository: + repository: https://github.com/VikiAnn/mastermind notes: "" evaluation: Fundamental Ruby & Style: 0 From b42eca27a79c42afcefb2a29534f48abd8b494b1 Mon Sep 17 00:00:00 2001 From: Rachel Warbelow Date: Thu, 25 Sep 2014 13:31:10 -0600 Subject: [PATCH 2/2] Update mastermind_submissions.yml --- 1409/01_mastermind/mastermind_submissions.yml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/1409/01_mastermind/mastermind_submissions.yml b/1409/01_mastermind/mastermind_submissions.yml index bff3922f7..e19b7841f 100644 --- a/1409/01_mastermind/mastermind_submissions.yml +++ b/1409/01_mastermind/mastermind_submissions.yml @@ -1,13 +1,17 @@ submissions: Alex Jensen: repository: https://github.com/danajensen/mastermind - notes: "" - evaluation: - Fundamental Ruby & Style: 0 - Enumerable & Collections: 0 - Test-Driven Development: 0 - REPL Interface: 0 - Breaking Logic into Components: 0 + notes: "Shows strong effort toward organization. Some closely-coupled objects. + Good use of best-choice enumerables (collect, any? zip). + Well-tested in isolation and integration. + Integrated difficulty level in REPL. Clear to use. + Saw intent to break apart logical components, but some objects tied together that will make future iterations or changes difficult to implement." + evaluation: + Fundamental Ruby & Style: 3.5 + Enumerable & Collections: 4 + Test-Driven Development: 4 + REPL Interface: 3.5 + Breaking Logic into Components: 3 Herbert Joseph: repository: https://github.com/Copywright/mastermind notes: "Don't kill me..."