Store WebSocket user data in upgrade handler

[arthuro555]

Hello 👋

I was wondering if it could be possible to store some user data in the upgrade handler.
I'd like to pass in a "roomID" parameters through the URL, verify if the user is allowed to join this room, and either block the establishment of a connection at this point, or, if the connection is allowed, store the roomID as a field of the UserData of the connection.

I guess I could do something like

let roomID;
app.ws("/:roomID/", {
  upgrade: (res, req, context) => {
    roomID = req.getParameter(0);
    res.upgrade(
      { url: req.getUrl() },
      req.getHeader('sec-websocket-key'),
      req.getHeader('sec-websocket-protocol'),
      req.getHeader('sec-websocket-extensions'),
      context
    );
  },
  open: (ws) => {
    ws.getUserData().roomID = roomID;
  },
}); 

According to the Upgrade example, open should be called immediately when upgrading so this should be safe to do... But that still feels very wrong and unsafe 😓 Is there any way to set the userData directly in the upgrade handler?

[uNetworkingAB]

https://unetworking.github.io/uWebSockets.js/generated/interfaces/HttpResponse.html#upgrade

[arthuro555]

Ah, sorry for this 😅 I assumed it was just a weird way to pass the URL in and that the upgrade handler required it, when looking at the example code... Thanks for your time 🙏

[uNetworkingAB]

yeah I understood that - better if the example used "myData" instead of "url" to really highlight it being something by user feel free to PR example change

[uNetworkingAB]

4774d92