Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

vis-academy examples do not seem to work with current version of deck.gl #69

Open
octopicorn opened this issue Sep 17, 2018 · 7 comments
Assignees

Comments

@octopicorn
Copy link

octopicorn commented Sep 17, 2018

Steps to reproduce:

  1. git clone vis-academy
  2. cd src/demos/2-scatterplot-overlay
  3. run yarn
  4. run yarn start
  5. observe on localhost:3030 that the scatterplot example is visible
  6. close web serve with cmd+C
  7. in package.json, upgrade the following:
"deck.gl": "^6.1.0",
"luma.gl": "^6.0.1",
"react-vis": "^1.11.1"

these are latest versions
8. now run yarn and then yarn start

Expected
Demo should still work, and render scatterplot

Actual
Scatteprlot does not render.

Error from console:

draw-layers.js:257 Uncaught TypeError: Cannot assign to read only property 'viewport' of object '[object Object]'
    at Function.assign (<anonymous>)
    at drawLayerInViewport (draw-layers.js:257)
    at draw-layers.js:229
    at Array.forEach (<anonymous>)
    at drawLayersInViewport (draw-layers.js:201)
    at draw-layers.js:89
    at Array.forEach (<anonymous>)
    at drawLayers (draw-layers.js:83)
    at draw-layers.js:132
    at withParameters (context-state.js:182)
@XiaokaiUber
Copy link

XiaokaiUber commented Sep 18, 2018

@octopicorn Please run yarn in the vis-academy folder first and then follow the steps you described above.

@balthazar
Copy link
Contributor

Your issue might be due to a breaking change introduced in the major release. Have you tried going through the changes before upgrading?

@ThomDietrich
Copy link

This doesn't seem all too surprising. For me the interesting question is if someone is going to update the vis-academy source code any time soon? Best!

@Bill-Q
Copy link

Bill-Q commented Oct 28, 2018

Same issue here. Using React 6.2.3
Got error:
Uncaught TypeError: Cannot assign to read only property 'viewport' of object '[object Object]' at Function.assign (<anonymous>) at drawLayerInViewport (draw-layers.js:262) at draw-layers.js:234 at Array.forEach (<anonymous>) at drawLayersInViewport (draw-layers.js:206) at draw-layers.js:94 at Array.forEach (<anonymous>) at drawLayers (draw-layers.js:88) at draw-layers.js:137 at withParameters (context-state.js:202) at drawPickingBuffer (draw-layers.js:131) at drawAndSamplePickingBuffer (pick-layers.js:218) at pickObject (pick-layers.js:64) at LayerManager.pickObject (layer-manager.js:374) at Deck._pickAndCallback (deck.js:504) at Deck._onPointerMove (deck.js:733) at Array.<anonymous> (event-manager.js:360) at Manager.emit (hammer.js:2525) at EventManager._onOtherEvent (event-manager.js:412) at MoveInput.handleEvent (move-input.js:139)

@Bill-Q
Copy link

Bill-Q commented Oct 28, 2018

An easy fix is to change the props variable name of viewpoint sent to the DeckGL. Such as
<DeckGLOverlay mainMapViewport={this.state.viewport} />

@varunpant
Copy link

varunpant commented Nov 12, 2018

Wondering if anyone will be fixing anything here ? P.S running yarn on root also fails.

I was trying to build examples in kepler.gl folder

ERROR in ./src/main.js
Module build failed: SyntaxError: Unexpected token (13:2)

  11 |
  12 | const Root = () => (
> 13 |   <Provider store={store}>
     |   ^
  14 |     <Router history={history}>
  15 |       <Route path="/" component={App} />
  16 |     </Router>

@XiaokaiUber
Copy link

@varunpant The examples run on my end. What steps did you take?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants