Emit server-added and server-removed stat on ringChanged event

btromanova · btromanova · commit ed22ffcd2863 · 2016-06-07T12:25:10.000+02:00
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,6 +4,7 @@ ringpop-node release notes
 Future
 -------
 * Remove tick-cluster.js, the version from ringpop-common should be used [#278](https://github.com/uber/ringpop-node/pull/278)
+* Emit server-added and server-removed stat on ringChanged event [#281](https://github.com/uber/ringpop-node/pull/281)
 
 10.15.0
 -------
diff --git a/lib/on_ring_event.js b/lib/on_ring_event.js
@@ -42,6 +42,8 @@ function createChecksumComputedHandler(ringpop) {
 function createRingChangedHandler(ringpop) {
     return function onRingChanged(event) {
         ringpop.stat('increment', 'ring.changed');
+        ringpop.stat('increment', 'ring.server-added', event.added);
+        ringpop.stat('increment', 'ring.server-removed', event.removed);
         ringpop.emit('ringChanged', event);
     };
 }

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,8 @@ function createChecksumComputedHandler(ringpop) {`
`42`	`42`	`function createRingChangedHandler(ringpop) {`
`43`	`43`	`return function onRingChanged(event) {`
`44`	`44`	`ringpop.stat('increment', 'ring.changed');`
	`45`	`+ ringpop.stat('increment', 'ring.server-added', event.added);`
	`46`	`+ ringpop.stat('increment', 'ring.server-removed', event.removed);`
`45`	`47`	`ringpop.emit('ringChanged', event);`
`46`	`48`	`};`
`47`	`49`	`}`