Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eos token #47

Open
hshi44 opened this issue Jun 6, 2023 · 0 comments
Open

Adding eos token #47

hshi44 opened this issue Jun 6, 2023 · 0 comments

Comments

@hshi44
Copy link

hshi44 commented Jun 6, 2023

In run_pplm_discrim_train.py get_generic_dataset() line 291:
if add_eos_token:
seq = [50256] + seq
I assume it addes an eos token to the sequence. However, it seems to be added at the beginning by these lines. Shouldn't eos be added to the end of the sequence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant