Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isBrowser should (probably) be isBrowser() in hi-res-timestamp.ts #191

Open
jeffpeck10x opened this issue May 3, 2022 · 1 comment
Open

Comments

@jeffpeck10x
Copy link

See here:
https://github.com/uber-web/probe.gl/blob/master/modules/log/src/utils/hi-res-timestamp.ts#L8

The imported isBrowser is a function that returns a boolean. It looks like that should be called isBrowser()

@ibgreen
Copy link
Collaborator

ibgreen commented May 3, 2022

I think it is actually exported as a constant: https://github.com/uber-web/probe.gl/blob/master/modules/env/src/utils/globals.ts#L9

I agree this can be confusing. We do export a similar constant from most of the vis.gl frameworks and I think it may indeed a function in one of them, which only adds to the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants