New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing a dir or a glob to the cli tool #51

Open

NameFILIP opened this issue Feb 21, 2019 · 1 comment

Contributor

NameFILIP commented Feb 21, 2019

Running thrift2flow ./idl/code.uber.internal/**/*.thrift works, but if I add it to package.json's scripts:

"idl-flow": "thrift2flow ./idl/code.uber.internal/**/*.thrift"

it stops working. I believe it's because my shell expands the glob expression while the scripts in package.json do not (see https://medium.com/@jakubsynowiec/you-should-always-quote-your-globs-in-npm-scripts-621887a2a784). It would be good to have an ability to pass either a folder or a glob to the CLI.

The text was updated successfully, but these errors were encountered:

Contributor Author

NameFILIP commented Feb 21, 2019

We can use something similar to what prettier, eslint and other CLI use, like https://github.com/mrmlnc/fast-glob or https://github.com/sindresorhus/globby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment