Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geosuggest is unable to catch google api error #428

Open
linzhaoken opened this issue Mar 27, 2019 · 5 comments
Open

Geosuggest is unable to catch google api error #428

linzhaoken opened this issue Mar 27, 2019 · 5 comments

Comments

@linzhaoken
Copy link

Short description

I was trying to create UI which will rendered differently if geosugget input has an google api error.

Expected results

I expected that should be a call back function such as onGoogleAPIError, so I will know there is an api issue and then render my ui accordingly.

Actual results

There is no way to know if google api call is failed.

@ro-ka
Copy link
Contributor

ro-ka commented Apr 5, 2019

Do you have a test setup where there is an Error?

@linzhaoken
Copy link
Author

I was catching the google place api error from browser console when my google api call is reach the limit. At that moment, I think if I can redesign my ui to produce an alternative ui if google place api is reach the limit.

@linzhaoken
Copy link
Author

So basically, It is good if we output place api response status.
image

@ro-ka
Copy link
Contributor

ro-ka commented Apr 8, 2019

That could be nice to have. If you want a feature like that, feel free to implement! A unified onApiError handler would be nice I think. We use three APIs and there should be at most 1 handler I think.

What do you think?

@linzhaoken
Copy link
Author

@ro-ka sure will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants