Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the errors returned by the geocoder API #486

Open
prateek3255 opened this issue Jun 12, 2021 · 0 comments · May be fixed by #487
Open

Handle the errors returned by the geocoder API #486

prateek3255 opened this issue Jun 12, 2021 · 0 comments · May be fixed by #487

Comments

@prateek3255
Copy link

Short description

The Geocoder.geocode method returns a promise, which is currently unhandled by the library, which results in unhandled errors.

Expected results

The geocoder errors should be appropriately propagated to the consumer via a prop.

Actual results

The library consumer is unaware of the error happening

Reproduction steps

Right now for some reason, the geocoder API errors out when the user enters a random text and presses enter, this error is also not propagated to the library consumer.

  1. Enter any random text in the geo suggest input
  2. Press enter
  3. View the unhandled error in the console

Additional Information

Image 2021-06-12 at 9 53 19 PM
prateek3255 added a commit to prateek3255/react-geosuggest that referenced this issue Jun 12, 2021
@prateek3255
fix(geocoder): Propogate geocoder error to consumer
afdce17 
closes ubilabs#486

Add a new prop to propogate errors from the Geocoder.geocode API to the consumer application
@prateek3255 prateek3255 linked a pull request Jun 12, 2021 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(geocoder): Propogate geocoder error to consumer prateek3255/react-geosuggest
1 participant
@prateek3255