-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling issues.assigned
for task-xp-guard
#94
Comments
I had a similar issue when using |
@Keyrxng did you try console logging the |
@Keyrxng can you show me the config you used? |
also I'm thinking that |
Agreed
I posted one here. But I tried a variety, the one posted just attempts to show my configuration in installing both:
I tried with |
Because I'm wondering if you set |
I think we could be doing with better naming conventions for plugin chaining lmao, just me that finds it slightly confusing when discussing chains?
I set plugins:
- uses:
# skipBotEvents: false
- plugin: http://localhost:4001
runsOn: [ "issues.assigned"]
skipBotEvents: false # seems to have no effect whether true or false
- uses:
- plugin: http://localhost:4000
runsOn: ["issue_comment.created"]
skipBotEvents: false |
@gentlementlegen I can't find the discussion but it was mentioned about the base event such as It shows in logs above that it's receiving the base event as a payload perhaps that has something to do with this problem @whilefoo? |
@Keyrxng the event logged does not represent the real event used, it is very likely |
It should be like this: plugins:
- uses:
- plugin: http://localhost:4001
runsOn: [ "issues.assigned"]
skipBotEvents: false
- uses:
- plugin: http://localhost:4000
runsOn: ["issue_comment.created"]
skipBotEvents: false |
😓 So it does work with the config set like this. My bad, although it's weird syntax I think because I think your idea to move this into the manifest is a better idea. I guess this will also be the solution for #98 |
plugins:
- skipBotEvents: false
uses:
- plugin: http://localhost:4001
runsOn: [ "issues.assigned"] but it is a bit confusing because there are two nested arrays |
Thanks for explaining, it makes more sense seeing that. |
Related to https://github.com/ubiquibot/task-xp-guard/pull/1
The issue is that after using the
/start
command anissues.assigned
event is fired but this line in the kernel skips the plugin becauseskipBotEvents
defaults totrue
and the sender of that event is the bot which is valid in regards toissues.assigned
/task-xp-guard
.Which is why I could only get it to run if I created a two-step chain passing the
issue_comment.created
event forward fromstart-stop
totask-xp-guard
My quick workaround below but is there a better way to handle this sort of thing? I have tried using
skipBotEvents: false
on both plugins with no success. The only thing that seems to work for me is below.see this QA - shows it failing to catch the event despite
skipBotEvents: false
in the configsee this QA - shows that with my workaround it kicks me as it should not only via direct UI assignment
The text was updated successfully, but these errors were encountered: