tests: various fixes & improvements to support packaging #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make for a clearer message if the test fails.
Instead of checking for a hardcoded "Dev", opt for the actual constant to make the test pass when we override it during Debian packaging.
GabrielNagy
force-pushed
the
fix-various-tests
branch
2 times, most recently
from
0a31376
to
d30cce1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 87.92% 87.70% -0.23%
==========================================
Files 29 29
Lines 2096 2106 +10
==========================================
+ Hits 1843 1847 +4
- Misses 195 199 +4
- Partials 58 60 +2 ☔ View full report in Codecov by Sentry. |
On my machine root isn't an active user so the active user test fails for me. Use the current user instead which is certain to be active, but fallback on root if the user doesn't have a set name.
We don't have a running system bus in chroot environments (e.g. Launchpad builders) so we need to create one ourselves.
GabrielNagy
force-pushed
the
fix-various-tests
branch
from
d30cce1
to
4fb41d5
Compare
denisonbarbosa
approved these changes
Nov 29, 2023
jibel
reviewed
Nov 29, 2023
| @@ -62,12 +63,18 @@ func (c *Cache) dumpToYaml() (string, error) { | |||
| c.mu.RLock() | |||
| defer c.mu.RUnlock() | |||
|
|
|||
| username := "root" | |||
| currentUser, _ := user.Current() | |||
There was a problem hiding this comment.
I think it's still good to catch and return the error here and let the test deal with it.
| @@ -104,6 +111,12 @@ func dbfromYAML(r io.Reader, destDir string) error { | |||
| return err | |||
| } | |||
|
|
|||
| username := "root" | |||
| currentUser, _ := user.Current() | |||
There was a problem hiding this comment.
same here, return the error if any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were prompted by failures during Launchpad tests (and running tests on my own machine). Details are in the individual commits.