Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: return user.Current error if any #119

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

GabrielNagy
Copy link
Contributor

Ignored the error initially to make the code shorter but I agree it's better to be explicit here.

Resolving the comments here #117 (comment)

Ignored the error initially to make the code shorter but I agree it's
better to be explicit here.
@GabrielNagy GabrielNagy requested a review from a team as a code owner November 29, 2023 13:48
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (570a972) 87.70% compared to head (655c0e1) 87.45%.

Files Patch % Lines
internal/cache/serialization.go 25.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   87.70%   87.45%   -0.25%     
==========================================
  Files          29       29              
  Lines        2106     2112       +6     
==========================================
  Hits         1847     1847              
- Misses        199      203       +4     
- Partials       60       62       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jibel jibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GabrielNagy GabrielNagy merged commit 2a2b732 into main Nov 29, 2023
5 checks passed
@GabrielNagy GabrielNagy deleted the return-serialization-error branch November 29, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants