Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proofs in fixtures #15

Open
bgins opened this issue Oct 2, 2023 · 0 comments
Open

Update proofs in fixtures #15

bgins opened this issue Oct 2, 2023 · 0 comments

Comments

@bgins
Copy link
Contributor

bgins commented Oct 2, 2023

Summary

Problem

Fixtures currently include a proof map like:

      "proofs": {
        "bafkreie3bfwr2pxtzphzpspb3plvdrh3obq5yiyibfuuiqj2m3kcrrexpu": "eyJhbGciOiJFZERTQSIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJkaWQ6a2V5Ono2TWtmZkRaQ2tDVFdyZWc4ODY4ZkcxRkdGb2djSmo1WDZQWTkzcFBjV0RuOWJvYiIsImNhcCI6e30sImV4cCI6OTI0NjIxMTIwMCwiaXNzIjoiZGlkOmtleTp6Nk1razg5YkMzSnJWcUtpZTcxWUVjYzVNMVNNVnh1Q2dOeDZ6TFo4U1lKc3hBTGkiLCJuYmYiOjEsInVjdiI6IjAuMTAuMCJ9.qvC6-4agkAxd72ZKNardHy8YHpKGAhz9sbNlWMys0LBoccifGCl-9Yz3bpy4SuosAbWy-W2tc5MGzFCNRmLpAw"
      }

but the ucan-http-bearer-token spec has been updated to put all proofs in a UCAN proof array: https://github.com/ucan-wg/ucan-http-bearer-token#23-example

Impact

The original intuition for proofs in a map no longer applies. In addition, an implementer might incorrectly cache proofs rather than computing their CIDs.

Solution

Present proofs as an array of tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant