Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow UDOIT to accept modern filetypes #900

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Allow UDOIT to accept modern filetypes #900

merged 6 commits into from
Apr 18, 2024

Conversation

taheralfayad
Copy link
Contributor

Fixes #899

@taheralfayad taheralfayad self-assigned this Mar 31, 2023
@taheralfayad taheralfayad added the javascript Pull requests that update Javascript code label Mar 31, 2023
@dmols dmols self-requested a review June 20, 2023 18:18
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix removes the error that prevented the "replacement" of files with one that has a modern extension, and vice-versa. However, it does not actually replace the file in question; it just adds the new file to the list of files for the course. This may be because there are references to said file that must be altered before the file can be fully replaced. Further discussion might be needed to decide how to tackle this problem.

@dmols
Copy link
Contributor

dmols commented Jun 30, 2023

It may have happened because of clearing my cache, but doing the process again no longer adds the file to the list of files NOR replace the file in question. This is also an issue in main . As of now, UDOIT allows the user to replace a file only if it has the same name. If it has a different name, nothing happens but we get the 'File Replaced' confirmation dialog still.

@dmols dmols removed the request for review from bagofarms July 11, 2023 19:22
@taheralfayad taheralfayad changed the title Allow UDOIT to accept modern filetypes WIP: Allow UDOIT to accept modern filetypes Aug 4, 2023
@taheralfayad taheralfayad added the php Pull requests that update Php code label Aug 4, 2023
@taheralfayad taheralfayad changed the title WIP: Allow UDOIT to accept modern filetypes Allow UDOIT to accept modern filetypes Apr 3, 2024
@taheralfayad
Copy link
Contributor Author

taheralfayad commented Apr 3, 2024

I just verified, when a file is uploaded through the review files modal, it replaces the file that it is intending to replace. This pull request should be ready for merge, pending @dmols review.

Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, great work! The only thing I would argue to add is a note mentioning that taking a look at the file and saving it as a docx, pptx, xlsx, etc, and re-uploading it, could fix the issue. Why I would add this note is because there's no way to replace a modern file with one that has the old extension. The alternative to this, is allowing them to replace modern filetypes with older filetypes, but we don't want to encourage that.

Lastly, good call adding the message in the english translation. I can add a similar one to the spanish translation, if it needs it.

@dmols
Copy link
Contributor

dmols commented Apr 18, 2024

Added spanish translation and made an issue (#940) to reword the modal message for finding incorrect/old filetypes. Clear to merge.

@dmols dmols self-requested a review April 18, 2024 21:17
@dmols dmols changed the base branch from main to dev April 18, 2024 21:18
@dmols dmols merged commit e04f201 into dev Apr 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug javascript Pull requests that update Javascript code php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UDOIT does not accept modern filetypes for classic counterparts [docx, pptx, xlsx]
2 participants