-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow UDOIT to accept modern filetypes #900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix removes the error that prevented the "replacement" of files with one that has a modern extension, and vice-versa. However, it does not actually replace the file in question; it just adds the new file to the list of files for the course. This may be because there are references to said file that must be altered before the file can be fully replaced. Further discussion might be needed to decide how to tackle this problem.
It may have happened because of clearing my cache, but doing the process again no longer adds the file to the list of files NOR replace the file in question. This is also an issue in |
I just verified, when a file is uploaded through the review files modal, it replaces the file that it is intending to replace. This pull request should be ready for merge, pending @dmols review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, great work! The only thing I would argue to add is a note mentioning that taking a look at the file and saving it as a docx, pptx, xlsx, etc, and re-uploading it, could fix the issue. Why I would add this note is because there's no way to replace a modern file with one that has the old extension. The alternative to this, is allowing them to replace modern filetypes with older filetypes, but we don't want to encourage that.
Lastly, good call adding the message in the english translation. I can add a similar one to the spanish translation, if it needs it.
Added spanish translation and made an issue (#940) to reword the modal message for finding incorrect/old filetypes. Clear to merge. |
Fixes #899