Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile and compose improvements #958

Merged
merged 3 commits into from
Sep 24, 2024
Merged

makefile and compose improvements #958

merged 3 commits into from
Sep 24, 2024

Conversation

SimHoZebs
Copy link
Contributor

Changes

  • container names are specified, ensuring no duplicate containers run under different directory names.
  • all set up commands can be accessed through make commands
  • database set up is a single make command instead of needing to work with the database manually

closes #948

@SimHoZebs SimHoZebs mentioned this pull request Aug 29, 2024
Merged
@dmols dmols changed the base branch from main to dev September 23, 2024 22:16
@dmols dmols self-requested a review September 23, 2024 22:16
@dmols dmols self-assigned this Sep 23, 2024
dmols
dmols approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and there's no conflicts with the dev branch. Great work!

@dmols dmols merged commit 6575ec0 into ucfopen:dev Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmols dmols dmols approved these changes

Assignees

@dmols dmols

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Makefile
2 participants
@SimHoZebs @dmols