Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using scaffold create and specifying a module causes the logger to issue warnings #37

Open
j2salmingo opened this issue Feb 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working priority:3 Low priority issue

Comments

@j2salmingo
Copy link

Used the following command:
bl-python-scaffold create -n test-scaffold -t openapi -m database

Scaffolding application named "test-scaffold" under directory `/home/jsalmingo/python_projects/test-scaffold`.
[INFO   ] Running create mode.
[INFO   ] Creating new application "test-scaffold" from openapi template ...

Enter a database connection string.
By default this is `sqlite:///:memory:?check_same_thread=False`.
Retain this default by pressing enter, or type something else.
>
[INFO   ] Using database connection string `sqlite:///:memory:?check_same_thread=False`
[WARNING] Directory `test-scaffold` exists. Files may be overwritten.
[WARNING] Directory `test-scaffold/test-scaffold` exists. Files may be overwritten.
[INFO   ] "test-scaffold" will be accessible at http://127.0.0.1:5000/test-scaffold
Done.

I am not sure what triggers the warning but it seems quite scary if this is normal operation.

It also appears that the link http://127.0.0.1:5000/test-scaffold will be available after installation but the application needs to be run first.

@j2salmingo j2salmingo added the documentation Improvements or additions to documentation label Feb 10, 2024
@aholmes
Copy link
Member

aholmes commented Feb 12, 2024

I need to think about this one. The warning exists for cases when someone may run the command where the files do exist before running the command, and also for the modify command when creating endpoints. However, the warning probably is not needed when the create command is first executed. This warning is largely an artifact of where the check is performed in the scaffolding process.

@aholmes aholmes added bug Something isn't working and removed documentation Improvements or additions to documentation labels Feb 12, 2024
@aholmes aholmes self-assigned this Feb 12, 2024
@aholmes aholmes added the priority:3 Low priority issue label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:3 Low priority issue
Projects
Status: Ready
Development

No branches or pull requests

2 participants