Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tox to manage dynamic options with pytest. #104

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

aholmes
Copy link
Member

@aholmes aholmes commented Sep 4, 2024

These changes support incoming updates to generated coverage reports for each separate library within the monorepo. Currently we can only get one big coverage report for the whole repo, which provides a "false" view of how well covered each individual library is. Unfortunately, the way --cov needs to be changed (and to continue supporting ease of use for developers), means some tool needs to be introduced to support the dynamism. Tox happens to fit this use case.

These changes support incoming updates to generated coverage reports for
each separate library within the monorepo. Currently we can only get one
big coverage report for the whole repo, which provides a "false" view of
how well covered each individual library is. Unfortunately, the way
`--cov` needs to be changed (and to continue supporting ease of use for
developers), means some tool needs to be introduced to support the
dynamism. Tox happens to fit this use case.
@aholmes aholmes marked this pull request as ready for review September 4, 2024 19:38
@aholmes aholmes requested a review from a team as a code owner September 4, 2024 19:38
Copy link
Member

@nwiltsie nwiltsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall - I've got one blocking question.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
nwiltsie
nwiltsie previously approved these changes Sep 5, 2024
This envvar is passed through without defining in the Tox config.
@aholmes aholmes merged commit 8d8768f into main Sep 5, 2024
12 checks passed
@aholmes aholmes deleted the aholmes-test-coverage branch September 5, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants