Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links at https://uclahs-cds.github.io/package-BoutrosLab-plotting-general/ #155

Open
tyamaguchi-ucla opened this issue Sep 17, 2023 · 7 comments
Assignees

Comments

@tyamaguchi-ucla
Copy link
Contributor

          @dan-knight looks like we need to fix links here as well. https://uclahs-cds.github.io/package-BoutrosLab-plotting-general/

Originally posted by @tyamaguchi-ucla in #153 (comment)

@dan-knight
Copy link
Contributor

Ah, looks like (for now) we need to manually rebuild and deploy the pkgdown site. We should look into automating this as well.

@jarbet Did you ever work on this with Stefan? Or are we starting from scratch?

@jarbet
Copy link
Contributor

jarbet commented Sep 20, 2023

Ah, looks like (for now) we need to manually rebuild and deploy the pkgdown site. We should look into automating this as well.

@jarbet Did you ever work on this with Stefan? Or are we starting from scratch?

@dan-knight: I have not worked with pkgdown before

@dan-knight
Copy link
Contributor

No worries. I'll look into doing it manually to get the hang of it, but it should be straightforward to automate with a GH action since it's running on GH Pages.

@dan-knight
Copy link
Contributor

Update: Using this r-lib example action as a guide, I can build and deploy from an action. This now begs the question: Should the pkgdown docs website be synced to themain branch, or to the latest release? In other words, should this run on every push to main, or just on releases? (Our decision here will apply to all R packages, and could even be extended to other types of repo if a similar thing exists in other languages.)

@lydiayliu
Copy link

Sorry is there an update on this? The links to specific plot pages seem to still be broken: https://uclahs-cds.github.io/public-R-BoutrosLab-plotting-general/reference/create.boxplot.html

@jarbet
Copy link
Contributor

jarbet commented Nov 16, 2023

https://uclahs-cds.github.io/public-R-BoutrosLab-plotting-general/reference/create.boxplot.html

@lydiayliu : I've been using this website instead, that @tyamaguchi-ucla sent me: https://github.com/uclahs-cds/package-BoutrosLab-plotting-general#function-reference

But I agree, it be good to fix the links in the github.io website version as well!

@lydiayliu
Copy link

thank you @jarbet, this is super helpful!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants