Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently not possible to turn off max_length #522

Open
lydiayliu opened this issue Jul 19, 2022 · 4 comments
Open

Currently not possible to turn off max_length #522

lydiayliu opened this issue Jul 19, 2022 · 4 comments
Assignees
@zhuchcn
Labels
enhancement New feature or request

Comments

@lydiayliu
Copy link
Collaborator

https://github.com/uclahs-cds/private-moPepGen/blob/badda70e42a46aca68be5f0381e11033d3ad435f/moPepGen/aa/VariantPeptidePool.py#L42-L43

From the code snipits I can find, it seems like min_length can be turned off by setting it to -1. Can we also turn off max_length by setting it to -1?
@lydiayliu lydiayliu added the priority: 2day Issue to be fixed in 2 or more days. label Jul 19, 2022
@zhuchcn
Copy link
Member

zhuchcn commented Jul 25, 2022

Have you tried setting it to "Inf"? It might work.

@zhuchcn
Copy link
Member

zhuchcn commented Jul 25, 2022

Have you tried setting it to "Inf"? It might work.

No it doesn't

@zhuchcn
Copy link
Member

zhuchcn commented Jul 25, 2022

Seems like setting it to be -1 is the only way.

@zhuchcn zhuchcn self-assigned this Jul 25, 2022
@lydiayliu
Copy link
Collaborator Author

I've never successfully set anything to inf in any programming language except when i do log(0) lolll

@lydiayliu lydiayliu added enhancement New feature or request and removed priority: 2day Issue to be fixed in 2 or more days. labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhuchcn zhuchcn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lydiayliu @zhuchcn