Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use singleID instead of normalID when there is only one sample from a patient #17

Open
shutaojccc opened this issue Sep 1, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@shutaojccc
Copy link

I used to use normalID and tumourID for N-T paired samples, and normalID when the sample is by itself. I later realized that the latter was kind of confusing because tumour sample alone can be used to run call-gSNP as well, and that using singleID when the sample is by itself would make more sense. Not urgent though.

@shutaojccc shutaojccc added the enhancement New feature or request label Sep 1, 2021
@yashpatel6
Copy link
Collaborator

Related:

We use sample_id for the overall sample identifier, ex. sample_id = S00-9422, normal_id = S00-9422N_079_114, tumour_id: S00-9422T_027_166. We should clean up the variable names in this pipeline though, there're some inconsistencies across the processes. I'll keep an issue open for this!

Originally posted by @yashpatel6 in #60 (comment)

Also clean up the inconsistent variable naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants