Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading TODO instruction on ERC721Mintable.sol #2

Open
albertsundjaja opened this issue May 25, 2019 · 0 comments
Open

Misleading TODO instruction on ERC721Mintable.sol #2

albertsundjaja opened this issue May 25, 2019 · 0 comments

Comments

@albertsundjaja
Copy link

//  TODO's: Create CustomERC721Token contract that inherits from the ERC721Metadata contract. You can name this contract as you please
//  1) Pass in appropriate values for the inherited ERC721Metadata contract
//      - make the base token uri: https://s3-us-west-2.amazonaws.com/udacity-blockchain/capstone/
//  2) create a public mint() that does the following:
//      -can only be executed by the contract owner
//      -takes in a 'to' address, tokenId, and tokenURI as parameters
//      -returns a true boolean upon completion of the function
//      -calls the superclass mint and setTokenURI functions

On the last part of the file TODO's point number 2 -takes in a 'to' address, tokenId, and tokenURI as parameters

tokenURI should not be needed and could confuse students, tokenURI is already defined in the contract before ERC721Metadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant