-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use access modifiers for the Auth struct. #4
Labels
moviemanagerchallenge
Task for "Improve the Movie Manager" Challenge
Comments
OwenLaRosa
added
the
moviemanagerchallenge
Task for "Improve the Movie Manager" Challenge
label
Nov 9, 2018
BrentMifsud
pushed a commit
to BrentMifsud/TheMovieManager
that referenced
this issue
Jun 2, 2019
BrentMifsud
pushed a commit
to BrentMifsud/TheMovieManager
that referenced
this issue
Jun 2, 2019
BrentMifsud
pushed a commit
to BrentMifsud/TheMovieManager
that referenced
this issue
Jun 2, 2019
BrentMifsud
pushed a commit
to BrentMifsud/TheMovieManager
that referenced
this issue
Jun 2, 2019
Well, I try on this.
|
nihalerdal
added a commit
to nihalerdal/TheMovieManager
that referenced
this issue
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TMDBClient
has anAuth
struct that gets modified to store the request token and session ID. These values are only accessed fromTMDBClient
, but they could be read or modified from another part of the app. This could potentially cause problems for debugging, as it's difficult to know which code modified the Auth values, but currently, there's no safeguard preventing someone from mistakenly modifying them outside ofTMDBClient
.To make the intent clearer, you can use Swift's access modifiers to restrict access to the
Auth
struct, to onlyTMDBClient
.The text was updated successfully, but these errors were encountered: