forked from NCAR/ccpp-physics
-
Notifications
You must be signed in to change notification settings - Fork 50
[production/RRFS.v1] Adds modifications to speed up RUCLSM #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MatthewPyle-NOAA
wants to merge
1,473
commits into
ufs-community:production/RRFS.v1
from
MatthewPyle-NOAA:feature/ruclsmspeedup
Closed
[production/RRFS.v1] Adds modifications to speed up RUCLSM #341
MatthewPyle-NOAA
wants to merge
1,473
commits into
ufs-community:production/RRFS.v1
from
MatthewPyle-NOAA:feature/ruclsmspeedup
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/mpas_nuopc_init
…nopy2 Adding Integrated Canopy Effects to CCPP/PBL Scheme
… into feature/mpas_nuopc_init
…an66: a) As the current large horizontal momentum diffusivity (Kh) at large-scale and meso-scale (LSMS) looks too large, Kh is computed at zl and modified as Kh=Kq=0.4*elmh*sqrt(tke), elmh=min(1.5*sqrt(zlup*zldn,500), where zlup is parcel's upward travel length and zldn is parcel's downward travel length with tke momentum. b) Scale-aware non-local mass flux (xmf, xmfd) is now given as xmf=(1-sigma)^2 * (sigma*wu) rather than the current xmf=pfnl*c1*wu, where wu is updraft velocity, c1 is a constant, sigma is updraft fraction, and pfnl is partition function for nonlocal flux. The constant c1 is the updraft fraction in LSMS and it should be sigma in small scales as sigma becomes larger than c1 in small scales. Also, the scale-awareness parameter, (1-sigma)^2, is more physically based following Arakawa and Wu's study than the empirical parameter, pfnl. c) Refinement of scl (height of 50% of max tke): max tke can be occasionally found in Jet stream and then scl would be too large. In the update, we look for max tke below 2.5km height and then compute scl and limit to 2.5km (i.e., scl=min(max(scl,500),2500)) d) ri(gradient Richardson number) is computed as ri=bf/shr2 (1dtke) rather than ri=bf/(def_1+def_2), where bf is buoyancy, because the parameters given as a function of ri (such as Prandtl number) is derived based on ri=bf/shr2. e) TTE-EDMF (total turbulent energy based EDMF scheme) is combined into sa3dtke scheme as it shows slightly better GFS forecast skill than tke-based scheme. The logical parameter to conduct TTE-EDMF is 'tte_edmf'.
Combination of 264,265,291 (MERRA2 3-hr, photochem diag, prog closure SFS)
… into feature/mpas_nuopc_init
…k that w3emc is using the expected precision
…k that w3emc is using the expected precision
…o 1000m for the 3DTKE option.
UFS-dev PR#311
address unreasonable large F0 and F1 in entrainment calculation
…composites_pre.F90
This PR changes the option relative_path in the CCPP metadata to dependencies_path as discussed in NCAR/ccpp-framework#685.
…_gjf Update of CDEPS inline sync without sfc_data
…cle_non6 Allow ihr to be non-multiples of 6
items once and reuse, rather than recomputing in each call to RUCLSM.
…_gjf2 fix bug in GFS_surface_composites_pre.F90
Collaborator
Author
|
Have it linked up in https://github.com/MatthewPyle-NOAA/ufs-weather-model/tree/feature/ruclsmspeedup |
…sync Create new scheme to get fields provided by CDEPS Inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Computes the TBQ table only once at the first call, and reuses the values in subsequent calls to RUCLSM rather than recomputing the same item repeatedly.
Tests Conducted:
Was tested in a canned RRFS case on WCOSS, and was a zero-diff change that sped things up by several percent in terms of run time.
Dependencies:
Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example:
Documentation:
Issue (optional):
Contributors (optional):
@dkokron provided this code speedup.