Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve naming consistency across dataset #46

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Improve naming consistency across dataset #46

wants to merge 35 commits into from

Conversation

samueljackson92
Copy link
Collaborator

@samueljackson92 samueljackson92 commented Dec 18, 2024 •
edited
Loading

Cannot be merged before: #44

Adds mappings for name consistency across shots and improved naming and structure for most of the datasets we care about for MAST-U and MAST.

To Test:

  • Run some example shots and check for consistency. For example 50900, 48912, and 45066
  • Code review.

@samueljackson92
Add new loader code
5b15ed5
@samueljackson92
Fix ruff
7178a9a
@samueljackson92
Update tests to conditionally skip
76ed719
@samueljackson92
Fix ruff
3184d9b
@samueljackson92
Update tests
185e8ce
@samueljackson92
revert to ignoring tests in CI until mastcodes is ready.
df8462e
@samueljackson92
Merge branch 'main' into 34-updated-reader
01ba84f
@samueljackson92
Skip more tests
0b23202
@samueljackson92
Refactor cli and workflow code
d32af1c
@samueljackson92
refactor pipelines
0aa1f9a
@samueljackson92
Update processing for amc
763278a
@samueljackson92
Add fix for names
c59d689
@samueljackson92
Update renaming dims
b5207d6
@samueljackson92
Update unit mappings
d6b5e21
@samueljackson92
Update workflow code
9bb6b53
@samueljackson92
Ruff formatting
a05baa5
@samueljackson92
Update requirements.txt
200731b
@samueljackson92
Update mappings
81d257f
@samueljackson92
Update CI
88d06bc
@samueljackson92
Update tests
f1d221d
@samueljackson92
fix ruff
3754551
@samueljackson92
Update workflow to upload to s3
82238e8
@samueljackson92
remove unused file
cbe659f
@samueljackson92
Add code to rename groups
51692ca
@samueljackson92
Tidy up name mappings
418cd84
@samueljackson92
Update mappings and pipelines for better harmony
b44d0a7
@samueljackson92 samueljackson92 added the enhancement New feature or request label Dec 18, 2024
@samueljackson92 samueljackson92 self-assigned this Dec 18, 2024
@samueljackson92 samueljackson92 linked an issue Dec 18, 2024 that may be closed by this pull request
Add additional mappings for renaming inconsistent variables #45
Open
@samueljackson92 samueljackson92 linked an issue Dec 18, 2024 that may be closed by this pull request
Flux maps from EFM still have incorrect radius #27
Open
@samueljackson92 samueljackson92 marked this pull request as ready for review January 2, 2025 16:08
@samueljackson92 samueljackson92 mentioned this pull request Jan 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samueljackson92 samueljackson92

Labels
enhancement New feature or request
Projects
None yet
Milestone
FCL Workshop Winter 2025
Development

Successfully merging this pull request may close these issues.

Add additional mappings for renaming inconsistent variables Flux maps from EFM still have incorrect radius
1 participant
@samueljackson92