Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddmmmm nitpicking #323

Open
danielrichman opened this issue Aug 11, 2015 · 1 comment
Open

ddmmmm nitpicking #323

danielrichman opened this issue Aug 11, 2015 · 1 comment

Comments

@danielrichman
Copy link
Member

https://github.com/ukhas/habitat/blob/develop/habitat/sensors/stdtelem.py#L74

Should this be "abs(minutes) > 60"?

Should it have a tolerance for floating point error?

@adamgreig
Copy link
Member

Looks like the only reason this works with negative ddmm.mmmm formats is luck. Probably could do with a quick rethink to make it more sensible.

I think it should probably read the minutes while the value is still a string and then not accept anything > 60.0 without further tolerance for floating point. No valid string of a minutes (0.00... up to 59.999...) will ever be turned into a floating point number where num>60.0 is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants