You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like the only reason this works with negative ddmm.mmmm formats is luck. Probably could do with a quick rethink to make it more sensible.
I think it should probably read the minutes while the value is still a string and then not accept anything > 60.0 without further tolerance for floating point. No valid string of a minutes (0.00... up to 59.999...) will ever be turned into a floating point number where num>60.0 is true.
https://github.com/ukhas/habitat/blob/develop/habitat/sensors/stdtelem.py#L74
Should this be "abs(minutes) > 60"?
Should it have a tolerance for floating point error?
The text was updated successfully, but these errors were encountered: