Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High bitdepth (> 8): Could not find a strategy for crc32c_8x8! #16

Open
L4cache opened this issue Mar 20, 2024 · 4 comments
Open

High bitdepth (> 8): Could not find a strategy for crc32c_8x8! #16

L4cache opened this issue Mar 20, 2024 · 4 comments

Comments

@L4cache
Copy link

L4cache commented Mar 20, 2024

Sorry for being so late, I encountered this problem several months ago.
Build is successful but when actually running the built binary the error occurs.
(mingw-w64 is used for building)
I've made a simple workaround, which appears to bypass the problem.
L4cache@484f5aa

@Jovasa
Copy link
Member

Jovasa commented Mar 25, 2024

Yes, we are aware of this and will fix it eventually. We haven't had the time to put too much effort on 10 bit encoding, thus there might be some problems with it.

@L4cache
Copy link
Author

L4cache commented Mar 28, 2024

Thanks, but before the real fix happens, is my workaround safe to use though? At least it can make the encoder produce bitstream rather than exits immediately, but I see Windows logs error in event log whenever the high bitdepth encoder "finishes" encode, I'm not sure if it's gonna break my encoding result.
By the way, the 8-bit encoder outputs bitstream with Main10 profile... I know it's in spec, but is it intentional?

@Jovasa
Copy link
Member

Jovasa commented Mar 29, 2024

Thanks, but before the real fix happens, is my workaround safe to use though?

As long as you don't use IBC, it should be OK.

At least it can make the encoder produce bitstream rather

Have you verified with VTM that the encoded bistream is valid?

I see Windows logs error in event log whenever the high bitdepth encoder "finishes" encode, I'm not sure if it's gonna break my encoding result.

Sound like the encoder might crash on when closing itself. This should not affect the produced bitstream. If I have time next week I'll try to investigate.

By the way, the 8-bit encoder outputs bitstream with Main10 profile... I know it's in spec, but is it intentional?

Currently the profile is hard coded so it defaults to the one that allows widest range of outputs.

@fador
Copy link
Member

fador commented Apr 30, 2024

By the way, the 8-bit encoder outputs bitstream with Main10 profile... I know it's in spec, but is it intentional?

I can add to this that I believe the Main profile used in previous standards was removed and Main10 is the new basic profile to be used also for 8-bit coding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants