You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the VOCIngestor._get_detection function parses bounding box coordinate values it decrements the values. Why is this so?
For example, if my image is 200 pixels wide and contains a box that's full width with xmin==0 and xmax==199 then this code results in a detection with left==-1 and right==198. Is this really what we want? It gives me trouble in this situation, in that it results in invalid boxes since -1 is out-of-range.
Also the box coordinate decrementations result in the box being pushed to the left/top by one pixel in every case. Is this really what we want? Perhaps there was some justification for the decrementations when the code was written that's just not obvious to me?
The text was updated successfully, but these errors were encountered:
When the
VOCIngestor._get_detection
function parses bounding box coordinate values it decrements the values. Why is this so?For example, if my image is 200 pixels wide and contains a box that's full width with xmin==0 and xmax==199 then this code results in a detection with left==-1 and right==198. Is this really what we want? It gives me trouble in this situation, in that it results in invalid boxes since -1 is out-of-range.
Also the box coordinate decrementations result in the box being pushed to the left/top by one pixel in every case. Is this really what we want? Perhaps there was some justification for the decrementations when the code was written that's just not obvious to me?
The text was updated successfully, but these errors were encountered: