Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable endpoint for S3 #169

Closed
mmalenic opened this issue Apr 30, 2023 · 1 comment
Closed

Add configurable endpoint for S3 #169

mmalenic opened this issue Apr 30, 2023 · 1 comment
Assignees

Comments

@mmalenic
Copy link
Member

The AWS SDK allows setting an endpoint for the S3 service - which is useful for running it locally or with MinIO. This value cannot be automatically set from environment variables using aws_config::load_from_env(), although this is an open feature request.

An Option should be added to S3Storage which allows setting an AWS endpoint, that can be passed down to AWSS3Storage and set with something like the S3 config builder set_endpoint_url function.

@brainstorm
Copy link
Member

Implemented in #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants