Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize storage by using Bytes in x/oracle vote object #1569

Open
4 tasks
robert-zaremba opened this issue Nov 10, 2022 · 0 comments
Open
4 tasks

Optimize storage by using Bytes in x/oracle vote object #1569

robert-zaremba opened this issue Nov 10, 2022 · 0 comments
Labels
C:x/oracle

Comments

@robert-zaremba
Copy link
Member

Summary

Problem Definition

As commented in https://github.com/umee-network/umee/pull/1538/files#diff-9acfbcafd261fcd25a836a19b506cc6ffefc86eaa7788eb765435718e36b1d52R20

we have lot of conversions back and forth between String and Bytes. Hash should be stored as bytes.

Proposal

Update x/oracle Vote proto and use bytes where possible.

NOTE: this is a breaking change.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/oracle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robert-zaremba