Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to the historacle proto #1655

Open
4 tasks
Tracked by #1521
zarazan opened this issue Dec 12, 2022 · 1 comment
Open
4 tasks
Tracked by #1521

Add comments to the historacle proto #1655

zarazan opened this issue Dec 12, 2022 · 1 comment
Assignees
Milestone

Comments

@zarazan
Copy link
Contributor

zarazan commented Dec 12, 2022

Summary

There was some confusion about if the denom used is symbol or base denom:
"For historacle MedianOfHistoricMedians(ctx, denom, numStamps), is denom the token’s base denom or symbol denom? Assuming symbol for now"

Problem Definition

Robert: "we need to add more comments to the proto."

Proposal

Add comments


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zarazan zarazan mentioned this issue Dec 12, 2022
17 tasks
@zarazan zarazan self-assigned this Dec 12, 2022
@robert-zaremba
Copy link
Member

We should also consider renaming. I was discussing similar thing for x/leverage with @toteki and we were brainstorming about few options, but didn't find ideal solution.

@robert-zaremba robert-zaremba added this to the v3.4 milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants