test: remaining incentive module unit tests #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2061 +/- ##
==========================================
- Coverage 75.38% 74.82% -0.57%
==========================================
Files 100 126 +26
Lines 8025 9632 +1607
==========================================
+ Hits 6050 7207 +1157
- Misses 1589 1948 +359
- Partials 386 477 +91
|
toteki
commented
May 22, 2023
toteki
commented
May 22, 2023
toteki
commented
May 22, 2023
There was a problem hiding this comment.
We should have more tests which can interface the flow... eg: bond --> unbond partially --> check if rewards were paid --> more people bond --> wait few blocks --> see if rewards are distributed correctly. I can create few tasks with specific flows we should test.
NOTE: Would be good to follow the KeeperBuilder pattern (but this is not blocking the PR).
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
robert-zaremba
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2005
progress: #1990
Note: What remains in #1990 is the leverage-side tests (basically
hooks_test.gobut run from the leverage module during its integration tests) and some edge cases.